From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933056Ab1KBSFr (ORCPT ); Wed, 2 Nov 2011 14:05:47 -0400 Received: from mail-ww0-f42.google.com ([74.125.82.42]:35088 "EHLO mail-ww0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755862Ab1KBSFq (ORCPT ); Wed, 2 Nov 2011 14:05:46 -0400 Message-ID: <1320257141.2292.24.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC> Subject: Re: Linux 3.1-rc9 From: Eric Dumazet To: Linus Torvalds Cc: Thomas Gleixner , Simon Kirby , David Miller , Peter Zijlstra , Linux Kernel Mailing List , Dave Jones , Martin Schwidefsky , Ingo Molnar , Network Development Date: Wed, 02 Nov 2011 19:05:41 +0100 In-Reply-To: References: <1318874090.4172.84.camel@twins> <1318879396.4172.92.camel@twins> <1318928713.21167.4.camel@twins> <20111018182046.GF1309@hostway.ca> <20111024190203.GA24410@hostway.ca> <20111025202049.GB25043@hostway.ca> <20111031173246.GA10614@hostway.ca> <1320254854.2292.14.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC> <1320256412.2292.17.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.0- Content-Transfer-Encoding: 8bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le mercredi 02 novembre 2011 à 11:00 -0700, Linus Torvalds a écrit : > On Wed, Nov 2, 2011 at 10:53 AM, Eric Dumazet wrote: > > > > tcp_v4_syn_recv_sock() > > { > > newsk = tcp_create_openreq_child(sk, req, skb); > > > > newsk is locked at this point. > > Umm, if that is the case, then the bug predates the commit you point > to. There were exit paths before that too. > Yes, but only when tproxy is used, and in some obscure error conditions... Probably nobody ever hit them or complained.