From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2C66C43334 for ; Mon, 18 Jul 2022 07:02:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233672AbiGRHCM (ORCPT ); Mon, 18 Jul 2022 03:02:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39496 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233184AbiGRHCL (ORCPT ); Mon, 18 Jul 2022 03:02:11 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 951EE167FE; Mon, 18 Jul 2022 00:02:09 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 6321A20B9D; Mon, 18 Jul 2022 07:02:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1658127727; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e5aQkIZVdYNM2zcinKIjum6VCc9vNyvSVPFP/u3Z0YM=; b=HBLVOt/xUv3wB5HYk/COSveHzUu8F6fwa0TuPhy1TmO+9PdlHLcCZTEh98VGtMQ5vDS7DV QTheRR1O0KB4/gmEYtdyTlqPln588/rL8gsvYRRfVXJXxSrX4dqcrJADxoqJ+6KDd3qPPf 8RROhYI0A7YcoyC8di+mMZa325s3hRQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1658127727; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e5aQkIZVdYNM2zcinKIjum6VCc9vNyvSVPFP/u3Z0YM=; b=mBZjQxi/IUi54PxfLtKVycZc13GmFFSWhntiAq5J5bdaLxrzyvD8zwPZvQl6Fij73drnxN hrZuKWIwU7whshCw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4344913754; Mon, 18 Jul 2022 07:02:07 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 253CD28F1WJbZwAAMHmgww (envelope-from ); Mon, 18 Jul 2022 07:02:07 +0000 Message-ID: <1320acde-2b39-a60c-14ca-9a64b4655006@suse.de> Date: Mon, 18 Jul 2022 09:02:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 05/10] md: factor out the rdev overlaps check from rdev_size_store Content-Language: en-US To: Christoph Hellwig , Song Liu Cc: Logan Gunthorpe , linux-raid@vger.kernel.org, linux-block@vger.kernel.org References: <20220718063410.338626-1-hch@lst.de> <20220718063410.338626-6-hch@lst.de> From: Hannes Reinecke In-Reply-To: <20220718063410.338626-6-hch@lst.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-raid@vger.kernel.org On 7/18/22 08:34, Christoph Hellwig wrote: > This splits the code into nicely readable chunks and also avoids > the refcount inc/dec manipulations. > > Signed-off-by: Christoph Hellwig > --- > drivers/md/md.c | 84 +++++++++++++++++++++++-------------------------- > 1 file changed, 39 insertions(+), 45 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes