All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Galbraith <efault@gmx.de>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: John Kacur <jkacur@redhat.com>,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	lkml <linux-kernel@vger.kernel.org>,
	rt-users <linux-rt-users@vger.kernel.org>
Subject: Re: [PATCH 2/2] Compile error with allmodconfig and CONFIG_PREEMPT_RT_FULL=y
Date: Wed, 16 Nov 2011 15:21:45 +0100	[thread overview]
Message-ID: <1321453305.15820.25.camel@marge.simson.net> (raw)
In-Reply-To: <1321363643.9105.13.camel@marge.simson.net>

On Tue, 2011-11-15 at 14:27 +0100, Mike Galbraith wrote:
> On Tue, 2011-11-15 at 07:23 -0500, Steven Rostedt wrote:
> 
> > Right, migrate_disable() should not have been an EXPORT_SYMBOL_GPL(), as
> > it is a helper functions that is also exported as EXPORT_SYMBOL(). It
> > shouldn't be called directly anyway, even by code in the kernel proper.
> 
> Ah.  Doesn't matter though.  I downloaded their latest, tried to build
> it with EXPORT_SYMBOL(migrate_enable/disable) ..
> 
> FATAL: modpost: GPL-incompatible module nvidia.ko uses GPL-only symbol '__rt_mutex_init'
> 
> With that exported, the thing builds and runs, but rt_mutex_foo exports
> appear to be intentionally GPL only, so it's "go fish" for nVidia.

Bah.  I checked the crusty old hack for crusty old driver, and it still
works just fine with a trivial define.  It'd probably work better if it
didn't need cheezy raw_* hacks, but then it'd probably work better if it
was GPL too ;-)

	-Mike


  parent reply	other threads:[~2011-11-16 14:21 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-14  1:44 [PATCH 1/2] v3.2-rc1-52e4c2a05-rt1 fix for compile break John Kacur
2011-11-14  1:44 ` John Kacur
2011-11-14  1:44 ` [PATCH 2/2] Compile error with allmodconfig and CONFIG_PREEMPT_RT_FULL=y John Kacur
2011-11-14 16:51   ` Paul E. McKenney
2011-11-14 17:39     ` John Kacur
2011-11-14 17:57       ` Paul E. McKenney
2011-11-14 20:51       ` Steven Rostedt
2011-11-14 21:07         ` John Kacur
2011-11-14 21:07           ` John Kacur
2011-11-15  5:22         ` Mike Galbraith
2011-11-15 12:23           ` Steven Rostedt
2011-11-15 13:27             ` Mike Galbraith
2011-11-15 13:45               ` Mike Galbraith
2011-11-16 14:21               ` Mike Galbraith [this message]
2012-04-13  5:34         ` SUSE question wrt RT locking primitives Mike Galbraith
2012-04-13 12:58           ` Steven Rostedt
2012-04-13 14:53             ` Mike Galbraith
2012-04-13 15:47               ` Thomas Gleixner
2011-11-14 16:50 ` [PATCH 1/2] v3.2-rc1-52e4c2a05-rt1 fix for compile break Paul E. McKenney
2011-11-14 20:57 ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1321453305.15820.25.camel@marge.simson.net \
    --to=efault@gmx.de \
    --cc=jkacur@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.