From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754790Ab1LGDSo (ORCPT ); Tue, 6 Dec 2011 22:18:44 -0500 Received: from mailout-de.gmx.net ([213.165.64.23]:41851 "HELO mailout-de.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752964Ab1LGDSn (ORCPT ); Tue, 6 Dec 2011 22:18:43 -0500 X-Authenticated: #14349625 X-Provags-ID: V01U2FsdGVkX19EriQgL8pECtP+rAtnyVkIVMRp44+uREvBONbLzs TnyKUkBtIGFFiv Subject: [resubmit] Re: [patch-final] Re: patch] cpusets, cgroups: disallow attaching kthreadd From: Mike Galbraith To: David Rientjes Cc: Andrew Morton , Paul Menage , LKML , Tejun Heo , Li Zefan , Peter Zijlstra In-Reply-To: References: <1316758874.7393.2.camel@marge.simson.net> <4E7C2E7F.40307@cn.fujitsu.com> <1316762345.8168.4.camel@marge.simson.net> <1316770936.6641.11.camel@marge.simson.net> <1316775204.7562.9.camel@marge.simson.net> <1316788392.6544.33.camel@marge.simson.net> <1318224892.6161.45.camel@marge.simson.net> <1318233815.6527.5.camel@marge.simson.net> <1318925436.9641.23.camel@marge.simson.net> <1319001860.6222.34.camel@marge.simson.net> <20111206144721.7b1d473d.akpm@linux-foundation.org> Content-Type: text/plain; charset="UTF-8" Date: Wed, 07 Dec 2011 04:18:34 +0100 Message-ID: <1323227914.5057.10.camel@marge.simson.net> Mime-Version: 1.0 X-Mailer: Evolution 2.32.1 Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2011-12-06 at 15:53 -0800, David Rientjes wrote: > Mike, would you mind resending the patch for the fourth or fifth time? If > not, I'll rebase it. Sure, below are the two candidates. I like Peter's idea better (door #2), "Keep yer grubby mitts offa _my_ Mom" is a natural reaction ;-) Door #1 From: Mike Galbraith cpusets, cgroups: disallow attaching kthreadd Allowing kthreadd to be moved to a non-root group makes no sense, it being a global resource, and needlessly leads unsuspecting users toward trouble. 1. An RT workqueue worker thread spawned in a task group with no rt_runtime allocated is not schedulable. Simple user error, but harmful to the box. 2. A worker thread which acquires PF_THREAD_BOUND can never leave a cpuset, rendering the cpuset immortal. Save the user some unexpected trouble, just say no. Signed-off-by: Mike Galbraith Acked-by: David Rientjes Acked-by: Paul Menage --- kernel/cpuset.c | 6 ++++-- kernel/sched/core.c | 10 ++++++++++ 2 files changed, 14 insertions(+), 2 deletions(-) Index: linux-3.0-tip/kernel/cpuset.c =================================================================== --- linux-3.0-tip.orig/kernel/cpuset.c +++ linux-3.0-tip/kernel/cpuset.c @@ -59,6 +59,7 @@ #include #include #include +#include /* * Workqueue for cpuset related tasks. @@ -1385,9 +1386,10 @@ static int cpuset_can_attach(struct cgro * set of allowed nodes is unnecessary. Thus, cpusets are not * applicable for such threads. This prevents checking for success of * set_cpus_allowed_ptr() on all attached tasks before cpus_allowed may - * be changed. + * be changed. We also disallow attaching kthreadd, to prevent it's + * child from becoming trapped should it then acquire PF_THREAD_BOUND. */ - if (tsk->flags & PF_THREAD_BOUND) + if (tsk->flags & PF_THREAD_BOUND || tsk == kthreadd_task) return -EINVAL; return 0; Index: linux-3.0-tip/kernel/sched/core.c =================================================================== --- linux-3.0-tip.orig/kernel/sched/core.c +++ linux-3.0-tip/kernel/sched/core.c @@ -71,6 +71,7 @@ #include #include #include +#include #include #include @@ -7461,6 +7462,15 @@ cpu_cgroup_destroy(struct cgroup_subsys static int cpu_cgroup_can_attach_task(struct cgroup *cgrp, struct task_struct *tsk) { + /* + * kthreadd can fork workers for an RT workqueue in a cgroup + * which may or may not have rt_runtime allocated. Just say no, + * as attaching a global resource to a non-root group doesn't + * make any sense anyway. + */ + if (tsk == kthreadd_task) + return -EINVAL; + #ifdef CONFIG_RT_GROUP_SCHED if (!sched_rt_can_attach(cgroup_tg(cgrp), tsk)) return -EINVAL; Door #2 From: Mike Galbraith cgroups: disallow attaching kthreadd Allowing kthreadd to be moved to a non-root group makes no sense, it being a global resource, and needlessly leads unsuspecting users toward trouble. 1. An RT workqueue worker thread spawned in a task group with no rt_runtime allocated is not schedulable. Simple user error, but harmful to the box. 2. A worker thread which acquires PF_THREAD_BOUND can never leave a cpuset, rendering the cpuset immortal. Save the user some unexpected trouble, just say no. Signed-off-by: Mike Galbraith --- kernel/cgroup.c | 9 +++++++++ 1 file changed, 9 insertions(+) Index: linux-3.0-tip/kernel/cgroup.c =================================================================== --- linux-3.0-tip.orig/kernel/cgroup.c +++ linux-3.0-tip/kernel/cgroup.c @@ -60,6 +60,7 @@ #include #include #include /* used in cgroup_attach_proc */ +#include #include @@ -1824,6 +1825,14 @@ int cgroup_attach_task(struct cgroup *cg struct cgroup *oldcgrp; struct cgroupfs_root *root = cgrp->root; + /* + * Workqueue threads may acquire PF_THREAD_BOUND and become + * trapped in a cpuset, or RT worker may be born in a cgroup + * with no rt_runtime allocated. Just say no. + */ + if (tsk == kthreadd_task) + return -EINVAL; + /* Nothing to do if the task is already in that cgroup */ oldcgrp = task_cgroup_from_root(tsk, root); if (cgrp == oldcgrp) Door #3