All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Richter <robert.richter@amd.com>
To: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>,
	Robert Richter <robert.richter@amd.com>
Subject: [PATCH 1/4] perf tools: Fix uninitialized memory access to struct perf_sample
Date: Thu, 15 Dec 2011 17:32:39 +0100	[thread overview]
Message-ID: <1323966762-8574-2-git-send-email-robert.richter@amd.com> (raw)
In-Reply-To: <1323966762-8574-1-git-send-email-robert.richter@amd.com>

Memory in struct perf_sample is not fully initialized during parsing.
Depending on sampling data some parts may left unchanged. Zero out
struct perf_sample first to avoid access to uninitialized memory.

Signed-off-by: Robert Richter <robert.richter@amd.com>
---
 tools/perf/util/evsel.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
index 4a8c8b0..ac115ba 100644
--- a/tools/perf/util/evsel.c
+++ b/tools/perf/util/evsel.c
@@ -457,7 +457,7 @@ int perf_event__parse_sample(const union perf_event *event, u64 type,
 		u32 val32[2];
 	} u;
 
-
+	memset(data, 0, sizeof(*data));
 	data->cpu = data->pid = data->tid = -1;
 	data->stream_id = data->id = data->time = -1ULL;
 
-- 
1.7.7



  reply	other threads:[~2011-12-15 16:34 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-15 16:32 [PATCH 0/4] perf tools: More fixes and updates Robert Richter
2011-12-15 16:32 ` Robert Richter [this message]
2011-12-21  8:41   ` [tip:perf/core] perf evsel: Fix uninitialized memory access to struct perf_sample tip-bot for Robert Richter
2011-12-15 16:32 ` [PATCH 2/4] perf record: Make feature initialization generic Robert Richter
2012-02-07 19:33   ` [tip:perf/core] " tip-bot for Robert Richter
2011-12-15 16:32 ` [PATCH 3/4] perf tools: Moving code in header.c Robert Richter
2011-12-15 16:32 ` [PATCH 4/4] perf tools: Factor out feature op to process header sections Robert Richter
2012-01-31 15:51 ` [PATCH 0/4] perf tools: More fixes and updates Robert Richter
2012-02-02 20:14   ` Arnaldo Carvalho de Melo
2012-02-10 11:31     ` Robert Richter
2012-02-10 14:30       ` Arnaldo Carvalho de Melo
2012-02-10 14:41         ` [PATCH 1/2] perf tools: Moving code in header.c Robert Richter
2012-02-10 14:41           ` [PATCH 2/2] perf tools: Factor out feature op to process header sections Robert Richter
2012-02-17  9:54             ` [tip:perf/core] " tip-bot for Robert Richter
2012-02-17  9:53           ` [tip:perf/core] perf tools: Moving code in header.c tip-bot for Robert Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1323966762-8574-2-git-send-email-robert.richter@amd.com \
    --to=robert.richter@amd.com \
    --cc=acme@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.