From mboxrd@z Thu Jan  1 00:00:00 1970
From: Pekka Enberg <penberg@kernel.org>
Subject: Re: [RFC 01/12] kvm tools: Split kvm_cmd_run into init, work and
 uninit
Date: Mon, 19 Dec 2011 23:26:16 +0200
Message-ID: <1324329976.1428.316.camel@jaguar>
References: <1324303114-5948-1-git-send-email-levinsasha928@gmail.com>
	 <1324303114-5948-2-git-send-email-levinsasha928@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
Cc: mingo@elte.hu, gorcunov@gmail.com, asias.hejun@gmail.com,
	kvm@vger.kernel.org
To: Sasha Levin <levinsasha928@gmail.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from filtteri2.pp.htv.fi ([213.243.153.185]:33450 "EHLO
	filtteri2.pp.htv.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752207Ab1LSV0T (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 19 Dec 2011 16:26:19 -0500
In-Reply-To: <1324303114-5948-2-git-send-email-levinsasha928@gmail.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Mon, 2011-12-19 at 15:58 +0200, Sasha Levin wrote:
> +int kvm_cmd_run(int argc, const char **argv, const char *prefix)
> +{
> +	int r, ret;
> +
> +	r = kvm_cmd_run_init(argc, argv);
> +	ret = kvm_cmd_run_work();
> +	r = kvm_cmd_run_uninit(ret);
> +
> +	return ret;
>  }

What's going on here? Why do you bother saving 'r' if you don't use it
for anything?

			Pekka