From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Update kerneldoc for intel_wm_need_update()
Date: Mon, 31 Dec 2018 15:05:43 +0000 [thread overview]
Message-ID: <13248587-6be2-2b7c-8978-b39ff878109c@linux.intel.com> (raw)
In-Reply-To: <20181231143505.2523-1-chris@chris-wilson.co.uk>
On 31/12/2018 14:35, Chris Wilson wrote:
> drivers/gpu/drm/i915/intel_display.c:10708: warning: Function parameter or member 'cur' not described in 'intel_wm_need_update'
> drivers/gpu/drm/i915/intel_display.c:10708: warning: Function parameter or member 'new' not described in 'intel_wm_need_update'
> drivers/gpu/drm/i915/intel_display.c:10708: warning: Excess function parameter 'plane' description in 'intel_wm_need_update'
> drivers/gpu/drm/i915/intel_display.c:10708: warning: Excess function parameter 'state' description in 'intel_wm_need_update'
>
> References: cd1d3ee90e5e ("drm/i915: Use intel_ types more consistently for watermark code (v2)")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Matt Roper <matthew.d.roper@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_display.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index f0a468cc0912..57fd5613c395 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -10695,8 +10695,8 @@ static void intel_crtc_destroy(struct drm_crtc *crtc)
>
> /**
> * intel_wm_need_update - Check whether watermarks need updating
> - * @plane: drm plane
> - * @state: new plane state
> + * @cur: current plane state
> + * @new: new plane state
> *
> * Check current plane state versus the new one to determine whether
> * watermarks need to be recalculated.
>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-12-31 15:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-31 14:35 [PATCH] drm/i915: Update kerneldoc for intel_wm_need_update() Chris Wilson
2018-12-31 14:44 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2018-12-31 15:04 ` ✓ Fi.CI.BAT: success " Patchwork
2018-12-31 15:05 ` Tvrtko Ursulin [this message]
2018-12-31 17:03 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13248587-6be2-2b7c-8978-b39ff878109c@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.