All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org, "Andreas Färber" <afaerber@suse.de>,
	"Avi Kivity" <avi@redhat.com>
Subject: [Qemu-devel] [PATCH 1/2] memory: Fix memory_region_wrong_endianness()
Date: Sat,  7 Jan 2012 09:45:14 +0100	[thread overview]
Message-ID: <1325925915-21477-2-git-send-email-afaerber@suse.de> (raw)
In-Reply-To: <1325925915-21477-1-git-send-email-afaerber@suse.de>

Since commit be675c972088eba210e18dc125613e9f205a6bfb (memory: move
endianness compensation to memory core) it was checking for
TARGET_BIG_ENDIAN instead of TARGET_WORDS_BIGENDIAN, thereby not
swapping correctly for Big Endian targets.

Signed-off-by: Andreas Färber <afaerber@suse.de>
Cc: Avi Kivity <avi@redhat.com>
---
 memory.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/memory.c b/memory.c
index 394cbab..5e55a90 100644
--- a/memory.c
+++ b/memory.c
@@ -843,7 +843,7 @@ static void memory_region_destructor_rom_device(MemoryRegion *mr)
 
 static bool memory_region_wrong_endianness(MemoryRegion *mr)
 {
-#ifdef TARGET_BIG_ENDIAN
+#ifdef TARGET_WORDS_BIGENDIAN
     return mr->ops->endianness == DEVICE_LITTLE_ENDIAN;
 #else
     return mr->ops->endianness == DEVICE_BIG_ENDIAN;
-- 
1.7.7

  reply	other threads:[~2012-01-07  8:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-07  8:45 [Qemu-devel] [PATCH 0/2] memory: Fix 'Kill old-style I/O dispatch' Andreas Färber
2012-01-07  8:45 ` Andreas Färber [this message]
2012-01-07  8:45 ` [Qemu-devel] [PATCH 2/2] memory: Fix adjust_endianness() Andreas Färber
2012-01-07 19:46 ` [Qemu-devel] [PATCH 0/2] memory: Fix 'Kill old-style I/O dispatch' Aurelien Jarno
2012-01-08 11:11 ` Avi Kivity
2012-01-08 17:13   ` Andreas Färber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1325925915-21477-2-git-send-email-afaerber@suse.de \
    --to=afaerber@suse.de \
    --cc=avi@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.