All of lore.kernel.org
 help / color / mirror / Atom feed
From: Corentin Chary <corentincj@iksaif.net>
To: platform-driver-x86@vger.kernel.org
Cc: "Zhang Rui" <rui.zhang@intel.com>,
	linux-kernel@vger.kernel.org,
	"Andrzej Prochyra" <andrzej@prochyra.name>,
	"Matthew Garrett" <mjg59@srcf.ucam.org>,
	"David Herrmann" <dh.herrmann@googlemail.com>,
	"Richard Schütz" <r.schtz@t-online.de>,
	"Seth Forshee" <seth.forshee@canonical.com>,
	"Len Brown" <lenb@kernel.org>,
	linux-acpi@vger.kernel.org,
	"Corentin Chary" <corentincj@iksaif.net>
Subject: [PATCH] ACPI / Video: blacklist some samsung laptops
Date: Sat,  7 Jan 2012 15:12:38 +0100	[thread overview]
Message-ID: <1325945558-4661-1-git-send-email-corentincj@iksaif.net> (raw)
In-Reply-To: <20120105150832.GA25386@ubuntu-macmini>

On these laptops, the ACPI video is not functional, and very unlikely
to be fixed by the vendor. Note that intel_backlight works for some
of these laptops, and the backlight from samsung-laptop always work.

The good news is that newer laptops have functional ACPI video device
and won't end up growing this list.

Signed-off-by: Corentin Chary <corentincj@iksaif.net>
---

Could the concerned people test this patch and check that it correctly
disable the acpi_video backlight ?

 drivers/acpi/video_detect.c |   40 ++++++++++++++++++++++++++++++++++++++++
 1 files changed, 40 insertions(+), 0 deletions(-)

diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c
index 45d8097..376bce2 100644
--- a/drivers/acpi/video_detect.c
+++ b/drivers/acpi/video_detect.c
@@ -132,6 +132,44 @@ find_video(acpi_handle handle, u32 lvl, void *context, void **rv)
 	return AE_OK;
 }
 
+/* Force to use vendor driver when the ACPI device is known to be
+ * buggy */
+static int video_detect_force_vendor(const struct dmi_system_id *d)
+{
+	acpi_video_support |= ACPI_VIDEO_BACKLIGHT_DMI_VENDOR;
+	return 0;
+}
+
+static struct dmi_system_id video_detect_dmi_table[] = {
+	{
+	 .callback = video_detect_force_vendor,
+	 .ident = "N150P",
+	 .matches = {
+		DMI_MATCH(DMI_SYS_VENDOR, "SAMSUNG ELECTRONICS CO., LTD."),
+		DMI_MATCH(DMI_PRODUCT_NAME, "N150P"),
+		DMI_MATCH(DMI_BOARD_NAME, "N150P"),
+		},
+	},
+	{
+	 .callback = video_detect_force_vendor,
+	 .ident = "N145P/N250P/N260P",
+	 .matches = {
+		DMI_MATCH(DMI_SYS_VENDOR, "SAMSUNG ELECTRONICS CO., LTD."),
+		DMI_MATCH(DMI_PRODUCT_NAME, "N145P/N250P/N260P"),
+		DMI_MATCH(DMI_BOARD_NAME, "N145P/N250P/N260P"),
+		},
+	},
+	{
+	 .callback = video_detect_force_vendor,
+	 .ident = "N150/N210/N220",
+	 .matches = {
+		DMI_MATCH(DMI_SYS_VENDOR, "SAMSUNG ELECTRONICS CO., LTD."),
+		DMI_MATCH(DMI_PRODUCT_NAME, "N150/N210/N220"),
+		DMI_MATCH(DMI_BOARD_NAME, "N150/N210/N220"),
+		},
+	},
+};
+
 /*
  * Returns the video capabilities of a specific ACPI graphics device
  *
@@ -164,6 +202,8 @@ long acpi_video_get_capabilities(acpi_handle graphics_handle)
 		 *		ACPI_VIDEO_BACKLIGHT_DMI_VENDOR;
 		 *}
 		 */
+
+		dmi_check_system(video_detect_dmi_table);
 	} else {
 		status = acpi_bus_get_device(graphics_handle, &tmp_dev);
 		if (ACPI_FAILURE(status)) {
-- 
1.7.5.4


  reply	other threads:[~2012-01-07 14:12 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-22 22:19 [PATCH] Platform: samsung-laptop: add DMI information for Samsung N150 Plus Andrzej Prochyra
2011-12-23 14:15 ` Corentin Chary
2011-12-24 14:12   ` Andrzej Prochyra
2011-12-24 14:20     ` Matthew Garrett
2011-12-24 14:28       ` David Herrmann
2011-12-26  9:49         ` Corentin Chary
2011-12-26 10:22           ` David Herrmann
2011-12-29 10:23             ` Corentin Chary
2011-12-29 11:45               ` Richard Schütz
2011-12-29 11:49                 ` Corentin Chary
2011-12-29 14:02                   ` David Herrmann
2012-01-04 20:51                   ` Seth Forshee
2012-01-05  7:18                     ` Corentin Chary
2012-01-05 15:08                       ` Seth Forshee
2012-01-07 14:12                         ` Corentin Chary [this message]
2012-01-08 10:46                           ` [PATCH] ACPI / Video: blacklist some samsung laptops Seth Forshee
2012-01-08 12:36                             ` Corentin Chary
2012-01-08 12:36                               ` Corentin Chary
2012-01-08 13:40                               ` Seth Forshee
2012-01-09 16:39                           ` David Herrmann
2012-01-09 22:34                             ` Andrzej Prochyra
2011-12-26  9:51     ` [PATCH] Platform: samsung-laptop: add DMI information for Samsung N150 Plus Corentin Chary
2011-12-26 12:33       ` Matthew Garrett
2012-01-23 10:41         ` Corentin Chary
2012-01-17  7:08 [PATCH] ACPI / Video: blacklist some samsung laptops Corentin Chary
2012-01-17 20:19 ` Seth Forshee
2012-01-30  8:26 ` Corentin Chary
2012-02-19 19:56   ` Corentin Chary
2012-02-20 11:06     ` David Herrmann
2012-02-20 14:27       ` Corentin Chary
2012-03-05  9:01 Corentin Chary

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1325945558-4661-1-git-send-email-corentincj@iksaif.net \
    --to=corentincj@iksaif.net \
    --cc=andrzej@prochyra.name \
    --cc=dh.herrmann@googlemail.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjg59@srcf.ucam.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=r.schtz@t-online.de \
    --cc=rui.zhang@intel.com \
    --cc=seth.forshee@canonical.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.