All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <ijc@hellion.org.uk>
To: u-boot@lists.denx.de
Subject: [U-Boot] v2011.12 and later do not boot on dreamplug.
Date: Thu, 12 Jan 2012 08:01:45 +0000	[thread overview]
Message-ID: <1326355305.29084.106.camel@dagon.hellion.org.uk> (raw)
In-Reply-To: <20120108225451.GE27130@titan.lakedaemon.net>

On Sun, 2012-01-08 at 17:54 -0500, Jason wrote:
> On Sun, Jan 08, 2012 at 07:49:05PM +0000, Ian Campbell wrote:
> > On Sun, 2012-01-08 at 15:30 +0000, Ian Campbell wrote:
> > diff --git a/drivers/spi/kirkwood_spi.c b/drivers/spi/kirkwood_spi.c
> > index dfe542d..db8ba8b 100644
> > --- a/drivers/spi/kirkwood_spi.c
> > +++ b/drivers/spi/kirkwood_spi.c
> > @@ -66,7 +66,7 @@ struct spi_slave *spi_setup_slave(unsigned int bus, unsigned int cs,
> >  	debug("data = 0x%08x \n", data);
> >  
> >  	writel(KWSPI_SMEMRDIRQ, &spireg->irq_cause);
> > -	writel(KWSPI_IRQMASK, spireg->irq_mask);
> > +	writel(KWSPI_IRQMASK, &spireg->irq_mask);
> >  
> >  	/* program mpp registers to select  SPI_CSn */
> >  	if (cs) {
> > -- 
> > 1.7.5.4
> 
> Acked-By: Jason Cooper <u-boot@lakedaemon.net>
> 
> Dammit.  My apologies.  I should've caught that.  Thanks for the patch.

No problem, was interesting to dig into u-boot for the first time!

Did I get the CC list right to cover whoever will eventually apply this
patch?

You are also working on upstreaming dreamplug support into Linux, is
that right? What is the current state of the art? I'm currently using a
3.1 kernel + patches from
http://people.debian.org/~zumbi/dreamplug/patches/ . (BTW feel free to
reply off list or switch to e.g. linux-arm-kernel since I guess this is
strict speaking off-topic here).

Thanks,
Ian.

-- 
Ian Campbell


Revolution, n.:
	A form of government abroad.

  reply	other threads:[~2012-01-12  8:01 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-08 15:30 [U-Boot] v2011.12 and later do not boot on dreamplug Ian Campbell
2012-01-08 15:35 ` Ian Campbell
2012-01-08 19:49 ` Ian Campbell
2012-01-08 22:54   ` Jason
2012-01-12  8:01     ` Ian Campbell [this message]
2012-01-12 15:11       ` Jason
2012-01-09 10:59   ` [U-Boot] Bug#655102: " Holger Brunck
2012-01-12 16:10   ` [U-Boot] [PATCH] kirkwood_spi: correct access to irq_mask register Ian Campbell
2012-01-12 16:22     ` Prafulla Wadaskar
2012-01-12 16:56       ` Ian Campbell
2012-01-27 16:34       ` Ian Campbell
2012-02-08  9:54         ` Prafulla Wadaskar
2012-02-09  6:30           ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1326355305.29084.106.camel@dagon.hellion.org.uk \
    --to=ijc@hellion.org.uk \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.