All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephan Linz <linz@li-pro.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] net: ll_temac: Remove useless memory erasing
Date: Sun, 15 Jan 2012 20:46:07 +0100	[thread overview]
Message-ID: <1326656767-28695-1-git-send-email-linz@li-pro.net> (raw)
In-Reply-To: <1326642366-22468-1-git-send-email-linz@li-pro.net>

In xilinx_ll_temac_initialize() the memory is already zero-ed
by the call to calloc, so this loop is useless.

Signed-off-by: Stephan Linz <linz@li-pro.net>
---
 drivers/net/xilinx_ll_temac.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/drivers/net/xilinx_ll_temac.c b/drivers/net/xilinx_ll_temac.c
index 8533358..e050250 100644
--- a/drivers/net/xilinx_ll_temac.c
+++ b/drivers/net/xilinx_ll_temac.c
@@ -387,10 +387,6 @@ int xilinx_ll_temac_initialize(bd_t *bis, struct ll_temac_info *devinf)
 	else
 		ll_temac->phyaddr = devinf->phyaddr;
 
-	/* Tell u-boot to get the addr from the env */
-	for (i = 0; i < 6; i++)
-		dev->enetaddr[i] = 0;
-
 	eth_register(dev);
 
 	/* Try to initialize PHY here, and return */
-- 
1.7.0.4

  parent reply	other threads:[~2012-01-15 19:46 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-15 15:41 [U-Boot] LL TEMAC V8 refactored Stephan Linz
2012-01-15 15:46 ` [U-Boot] [PATCH 1/5] net: ll_temac: Add LL TEMAC driver to u-boot Stephan Linz
2012-01-15 17:28   ` Mike Frysinger
2012-01-15 18:29     ` Stephan Linz
2012-01-15 18:47       ` Mike Frysinger
2012-01-15 19:41         ` Stephan Linz
2012-01-16  8:19           ` Wolfgang Denk
2012-01-17 20:19         ` Stephan Linz
2012-01-16  8:14       ` Wolfgang Denk
2012-01-16 17:46         ` Stephan Linz
2012-01-15 19:46   ` Stephan Linz [this message]
2012-01-15 23:44     ` [U-Boot] [PATCH] net: ll_temac: Remove useless memory erasing Mike Frysinger
2012-01-16 17:22       ` Stephan Linz
2012-01-16  8:06     ` Wolfgang Denk
2012-01-15 15:46 ` [U-Boot] [PATCH 2/5] microblaze: Enable several ethernet driver compilation Stephan Linz
2012-01-15 15:46 ` [U-Boot] [PATCH 3/5] microblaze: Wire up LL_TEMAC driver initialization Stephan Linz
2012-01-15 15:46 ` [U-Boot] [PATCH 4/5] microblaze: Enable phylib and mii support Stephan Linz
2012-01-15 15:46 ` [U-Boot] [PATCH 5/5] microblaze: Add faked LL_TEMAC driver configuration Stephan Linz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1326656767-28695-1-git-send-email-linz@li-pro.net \
    --to=linz@li-pro.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.