From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Date: Fri, 27 Jan 2012 16:34:11 +0000 Subject: [U-Boot] [PATCH] kirkwood_spi: correct access to irq_mask register In-Reply-To: References: <1326052145.29084.72.camel@dagon.hellion.org.uk> <1326384622-22489-1-git-send-email-ijc@hellion.org.uk> Message-ID: <1327682057.26983.193.camel@zakaz.uk.xensource.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thu, 2012-01-12 at 08:22 -0800, Prafulla Wadaskar wrote: > > > -----Original Message----- > > From: Ian Campbell [mailto:ijc at hellion.org.uk] > > Sent: 12 January 2012 21:40 > > To: u-boot at lists.denx.de > > Cc: Ian Campbell; Prafulla Wadaskar; Albert ARIBAUD > > Subject: [PATCH] kirkwood_spi: correct access to irq_mask register > > > > Problem appears to have been present since day one but masked because > > alignment > > aborts were not enabled. ca4b55800ed7 "arm, arm926ejs: always do cpu > > critical > > inits" turned on alignment aborts and uncovered this latent problem. > > > > Signed-off-by: Ian Campbell > > Acked-By: Jason Cooper > > Tested-By: Holger Brunck > > Cc: Prafulla Wadaskar > > Cc: Albert ARIBAUD > > --- > > v2: Resending per patch submission guidelines. > > --- > > drivers/spi/kirkwood_spi.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/drivers/spi/kirkwood_spi.c b/drivers/spi/kirkwood_spi.c > > index dfe542d..db8ba8b 100644 > > --- a/drivers/spi/kirkwood_spi.c > > +++ b/drivers/spi/kirkwood_spi.c > > @@ -66,7 +66,7 @@ struct spi_slave *spi_setup_slave(unsigned int bus, > > unsigned int cs, > > debug("data = 0x%08x \n", data); > > > > writel(KWSPI_SMEMRDIRQ, &spireg->irq_cause); > > - writel(KWSPI_IRQMASK, spireg->irq_mask); > > + writel(KWSPI_IRQMASK, &spireg->irq_mask); > > > > /* program mpp registers to select SPI_CSn */ > > if (cs) { > > Hi Ian > Thanks for the patch (resend :-) ) > Actually it was in my pipeline. > I will pull this ASAP as well as other patches in my plate. Ping? This patch doesn't seem to be in git yet. Ian. -- Ian Campbell Current Noise: Iron Monkey - 9 Joint Spiritual Whip "Were there no women, men might live like gods." -- Thomas Dekker