From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D0D7DC433F5 for ; Tue, 17 May 2022 15:26:01 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 24696112FC6; Tue, 17 May 2022 15:26:01 +0000 (UTC) Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by gabe.freedesktop.org (Postfix) with ESMTPS id B38C3112FC6 for ; Tue, 17 May 2022 15:26:00 +0000 (UTC) Received: by mail-lf1-x132.google.com with SMTP id d15so31946727lfk.5 for ; Tue, 17 May 2022 08:26:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=V+X+LRsejpzXZH7tsox7umkRY7xo5WQxZtVa62UBNjU=; b=MAvqRFZMqTF2/qVoqgWL5T0C+ULSZS7SdHzVh6LuDRdT51k+tjmab0c7gpzsf0Ql7k ReP/eAAoQU51GsQD4Bz0ywyVLUNnZh/mE3GNKvawkR7gvPqBw5mXHXDDgdkNrpfTpAs1 bAMk6xyeJ1g4mnjcaeSQMvlpPsF4rbwLd+zy7LuQWikYbxdBzh0GZpJaYHhJxcWDRPdr liBJ3i5eBbWp55RwkiZwR+iHlOp6uft4OXTRqqT9OHhoOaU24sAJ7WOwFhn0hed1CrBs PnWxpalasLu5anySlBVesTRozNRF6F1oQ8HwZT5nEhEcwxQOOhte+RNCH6dwDZuqzYvq U0Sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=V+X+LRsejpzXZH7tsox7umkRY7xo5WQxZtVa62UBNjU=; b=itZgOxFTaxXQZHDzCHhT3YS2/YksQnI1zrD5VlA5ZzICmLfpKRWFY5gor0bgD1ewu7 z6XC5wZEv1mtoLT+7uE+ltknCiO9oFpvJO3Y5S+J+pPtFpkusrnM5rqtF4mJs+o4w4sf PPS6RTy0X5+0TafsqB8fmzYqd7dsJXJE/cYFYMlWEDaaXIfsxFeBX1J8KVuWcD102+6+ u8MlJvr0yV8Yv66MOa9u4KBC+lW7r2Ykigveo+sLPOEH0RpZ8z8F/1nCVpj8dYWX89So GbZruKu6CgXWYZbzqpSOobOyflCAT016J9vRCZySugKkErcgejiXfzVDvkALk41lSReU 7z9w== X-Gm-Message-State: AOAM530LjNJKKv06OpEKxovTe/Z17KCmGNGbx1jvSVFfqrEQFBs0J+XP VETFGfC1aEagWsJOLYWGVoArkQ== X-Google-Smtp-Source: ABdhPJxmP1/fh87kksGIF64YeOa63xcO4AZZoPfdVcUnKNeeAX7gyD0GjdDyznBoSgv6nNdqeC5cBA== X-Received: by 2002:a05:6512:280e:b0:473:a0c9:5bdf with SMTP id cf14-20020a056512280e00b00473a0c95bdfmr17199543lfb.337.1652801159066; Tue, 17 May 2022 08:25:59 -0700 (PDT) Received: from [192.168.0.17] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id v2-20020a056512348200b0047255d21124sm2221lfr.83.2022.05.17.08.25.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 May 2022 08:25:57 -0700 (PDT) Message-ID: <1327ec95-f6b4-838d-f3f2-a115c2ab632b@linaro.org> Date: Tue, 17 May 2022 17:25:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v2 2/3] ARM: dts: aspeed: Add USB2.0 device controller node Content-Language: en-US To: Neal Liu , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Joel Stanley , Andrew Jeffery , Felipe Balbi , Sumit Semwal , =?UTF-8?Q?Christian_K=c3=b6nig?= , Geert Uytterhoeven , Li Yang References: <20220517082558.3534161-1-neal_liu@aspeedtech.com> <20220517082558.3534161-3-neal_liu@aspeedtech.com> <96973d1d-c52c-d190-6989-3f7996dae70b@linaro.org> <0bc5ba24-5bfb-593e-cbd0-828ef44aabc5@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devicetree@vger.kernel.org" , "linux-aspeed@lists.ozlabs.org" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "linaro-mm-sig@lists.linaro.org" , "linux-arm-kernel@lists.infradead.org" , "linux-media@vger.kernel.org" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 17/05/2022 17:21, Neal Liu wrote: >>>>> >>>>> + udc: udc@1e6a2000 { >>>> >>>> The same as DTS in bindings - generic node name, please. >>>> >>> >>> Is it possible to use "udc: usb-udc@1e6a2000" to distinguish it between "vhub: >> usb-vhub@1e6a0000"? >> >> Possible yes :), but not recommended and not wanted. Nodes should be generic >> and prefixes are added only if there is no unit address. You can though use >> some more descriptive label. >> > "udc: usb@1e6a2000" is okay for you? Yes, it's perfect. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E6E3C433F5 for ; Tue, 17 May 2022 15:26:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349968AbiEQP0p (ORCPT ); Tue, 17 May 2022 11:26:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38988 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349914AbiEQP0C (ORCPT ); Tue, 17 May 2022 11:26:02 -0400 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AC4E4B1DD for ; Tue, 17 May 2022 08:26:00 -0700 (PDT) Received: by mail-lf1-x12e.google.com with SMTP id t25so31949343lfg.7 for ; Tue, 17 May 2022 08:26:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=V+X+LRsejpzXZH7tsox7umkRY7xo5WQxZtVa62UBNjU=; b=MAvqRFZMqTF2/qVoqgWL5T0C+ULSZS7SdHzVh6LuDRdT51k+tjmab0c7gpzsf0Ql7k ReP/eAAoQU51GsQD4Bz0ywyVLUNnZh/mE3GNKvawkR7gvPqBw5mXHXDDgdkNrpfTpAs1 bAMk6xyeJ1g4mnjcaeSQMvlpPsF4rbwLd+zy7LuQWikYbxdBzh0GZpJaYHhJxcWDRPdr liBJ3i5eBbWp55RwkiZwR+iHlOp6uft4OXTRqqT9OHhoOaU24sAJ7WOwFhn0hed1CrBs PnWxpalasLu5anySlBVesTRozNRF6F1oQ8HwZT5nEhEcwxQOOhte+RNCH6dwDZuqzYvq U0Sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=V+X+LRsejpzXZH7tsox7umkRY7xo5WQxZtVa62UBNjU=; b=LEj9Iq4YYB9PwlVKRNz76erOrLxwNIG8ETgS4WLMf8wKGKcFzcIfc/dMTN/dwBIFtB Z4sYMty8+LEb65wub9tSDaJtt+O91qIr0PbrOTEsHnMZroRjiu1CPVr+qVen3htTgmm6 5QkOK4hUl5P33uKOdf6XCKf9kgNpKJ4/8IdWYa8m5KhODPRbBbYFe+kpTafSaHcPHkOr R2R1ANpKcgKmUxR7tDtpv5FsspMepBj6VjZqsR8+PCEs0qcjBuBXgrwkQNzPmjK1meKu ySj+wMgr6Vqdpq47OL2Q6+IlTtwMwLwqEmp1eXU47igMLb04YDfhITHdFq0w/c5BOBiP 4TBw== X-Gm-Message-State: AOAM530uOUpPodM8QKCiILSd1y7VHZu+pz5BbEY27Os69Oy8VqFLWUZ5 018OxvBVGTbS66uCqYPWOH0zXQ== X-Google-Smtp-Source: ABdhPJxmP1/fh87kksGIF64YeOa63xcO4AZZoPfdVcUnKNeeAX7gyD0GjdDyznBoSgv6nNdqeC5cBA== X-Received: by 2002:a05:6512:280e:b0:473:a0c9:5bdf with SMTP id cf14-20020a056512280e00b00473a0c95bdfmr17199543lfb.337.1652801159066; Tue, 17 May 2022 08:25:59 -0700 (PDT) Received: from [192.168.0.17] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id v2-20020a056512348200b0047255d21124sm2221lfr.83.2022.05.17.08.25.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 May 2022 08:25:57 -0700 (PDT) Message-ID: <1327ec95-f6b4-838d-f3f2-a115c2ab632b@linaro.org> Date: Tue, 17 May 2022 17:25:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v2 2/3] ARM: dts: aspeed: Add USB2.0 device controller node Content-Language: en-US To: Neal Liu , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Joel Stanley , Andrew Jeffery , Felipe Balbi , Sumit Semwal , =?UTF-8?Q?Christian_K=c3=b6nig?= , Geert Uytterhoeven , Li Yang Cc: "linux-aspeed@lists.ozlabs.org" , "linux-usb@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-media@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "linaro-mm-sig@lists.linaro.org" References: <20220517082558.3534161-1-neal_liu@aspeedtech.com> <20220517082558.3534161-3-neal_liu@aspeedtech.com> <96973d1d-c52c-d190-6989-3f7996dae70b@linaro.org> <0bc5ba24-5bfb-593e-cbd0-828ef44aabc5@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17/05/2022 17:21, Neal Liu wrote: >>>>> >>>>> + udc: udc@1e6a2000 { >>>> >>>> The same as DTS in bindings - generic node name, please. >>>> >>> >>> Is it possible to use "udc: usb-udc@1e6a2000" to distinguish it between "vhub: >> usb-vhub@1e6a0000"? >> >> Possible yes :), but not recommended and not wanted. Nodes should be generic >> and prefixes are added only if there is no unit address. You can though use >> some more descriptive label. >> > "udc: usb@1e6a2000" is okay for you? Yes, it's perfect. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 71DB6C433F5 for ; Tue, 17 May 2022 15:27:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SZPrhylAnrXX8Homh8QfREO7+qg5mCTBEAMN9phZMl4=; b=B8IX6N8BKU8GNM Gr8AGyG28ggbvP8l8HmcWkjYZvaWOEstPCXOU/vsHQMMAaAeY3fj9ag4K60/qJygXdOIEKRAss5Yl /Xne+xq0HexDei0IKckDeKd5UUNawZVoHPnZTkLNTt9a1k3NIn94HLwM26kpZ4dCd4zWFqHLwmTNf qYEFQDzEJtcT2zT3s6lY1CHiZAvNSUGx74EGN51vabnpKhGlnNrlMcKTWBX7TdC7SJde3r4OAkWGK UdLjB5k34oRdJkdPbb8Y95Iko4ROnAwkfH7lnpucGHw+ZH7kXIyUGb4jkY3QK76brI1D4EzEk7Rxm qtifinPQAGb2Eh0fPT3g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nqz5K-00EgB0-Ug; Tue, 17 May 2022 15:26:07 +0000 Received: from mail-lf1-x12b.google.com ([2a00:1450:4864:20::12b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nqz5E-00Eg99-Re for linux-arm-kernel@lists.infradead.org; Tue, 17 May 2022 15:26:04 +0000 Received: by mail-lf1-x12b.google.com with SMTP id c24so22471271lfv.11 for ; Tue, 17 May 2022 08:26:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=V+X+LRsejpzXZH7tsox7umkRY7xo5WQxZtVa62UBNjU=; b=MAvqRFZMqTF2/qVoqgWL5T0C+ULSZS7SdHzVh6LuDRdT51k+tjmab0c7gpzsf0Ql7k ReP/eAAoQU51GsQD4Bz0ywyVLUNnZh/mE3GNKvawkR7gvPqBw5mXHXDDgdkNrpfTpAs1 bAMk6xyeJ1g4mnjcaeSQMvlpPsF4rbwLd+zy7LuQWikYbxdBzh0GZpJaYHhJxcWDRPdr liBJ3i5eBbWp55RwkiZwR+iHlOp6uft4OXTRqqT9OHhoOaU24sAJ7WOwFhn0hed1CrBs PnWxpalasLu5anySlBVesTRozNRF6F1oQ8HwZT5nEhEcwxQOOhte+RNCH6dwDZuqzYvq U0Sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=V+X+LRsejpzXZH7tsox7umkRY7xo5WQxZtVa62UBNjU=; b=0bLGdRdf995rZudQRM3diBAtcbhXkdYwZml3/J77/GkPVJHL9k9QPpjqUfVBwt1jLU KY8mBd4/+t99DhNSOHDNPCx+4uUwJPnPUx50XBSb6UNWsyMFJXzEq7FBYBgZGS2ey6du AmDaTaGn7AUuV5SsaSb0szGTa4tbnhrNtteJeVm5jfK2rjuPDJUpNtCnVQeI0utIZmRp 5zyl55+3GjT/fi5Tafp1Z+5pPb6lhxvPeoTzxZH3uy17ofOJDw0Yb2WQJI4bvj9yTM0j TMXpmjyCXVwnMaRTE/PCHEC9/T53mmcL1Knxx/zF1NOAvYsCfa2Aio9vzSLNmRqI4z6L L67Q== X-Gm-Message-State: AOAM5310KdfrEjujFqeCnZDmhvN1kuiaIbYgAgLMLoce5EDh0pHQk3Zb J6hcL6z6YoUhJgeEN3RdAW8SIKTxx396SVWW X-Google-Smtp-Source: ABdhPJxmP1/fh87kksGIF64YeOa63xcO4AZZoPfdVcUnKNeeAX7gyD0GjdDyznBoSgv6nNdqeC5cBA== X-Received: by 2002:a05:6512:280e:b0:473:a0c9:5bdf with SMTP id cf14-20020a056512280e00b00473a0c95bdfmr17199543lfb.337.1652801159066; Tue, 17 May 2022 08:25:59 -0700 (PDT) Received: from [192.168.0.17] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id v2-20020a056512348200b0047255d21124sm2221lfr.83.2022.05.17.08.25.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 May 2022 08:25:57 -0700 (PDT) Message-ID: <1327ec95-f6b4-838d-f3f2-a115c2ab632b@linaro.org> Date: Tue, 17 May 2022 17:25:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v2 2/3] ARM: dts: aspeed: Add USB2.0 device controller node Content-Language: en-US To: Neal Liu , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Joel Stanley , Andrew Jeffery , Felipe Balbi , Sumit Semwal , =?UTF-8?Q?Christian_K=c3=b6nig?= , Geert Uytterhoeven , Li Yang Cc: "linux-aspeed@lists.ozlabs.org" , "linux-usb@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-media@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "linaro-mm-sig@lists.linaro.org" References: <20220517082558.3534161-1-neal_liu@aspeedtech.com> <20220517082558.3534161-3-neal_liu@aspeedtech.com> <96973d1d-c52c-d190-6989-3f7996dae70b@linaro.org> <0bc5ba24-5bfb-593e-cbd0-828ef44aabc5@linaro.org> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220517_082600_959901_F4C538F9 X-CRM114-Status: GOOD ( 10.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 17/05/2022 17:21, Neal Liu wrote: >>>>> >>>>> + udc: udc@1e6a2000 { >>>> >>>> The same as DTS in bindings - generic node name, please. >>>> >>> >>> Is it possible to use "udc: usb-udc@1e6a2000" to distinguish it between "vhub: >> usb-vhub@1e6a0000"? >> >> Possible yes :), but not recommended and not wanted. Nodes should be generic >> and prefixes are added only if there is no unit address. You can though use >> some more descriptive label. >> > "udc: usb@1e6a2000" is okay for you? Yes, it's perfect. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel