From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: [PATCH v2 00/10] Add PWM framework and device-tree support. Date: Mon, 6 Feb 2012 16:19:35 +0100 Message-ID: <1328541585-24642-1-git-send-email-thierry.reding@avionic-design.de> Return-path: Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Sascha Hauer , Arnd Bergmann , Matthias Kaehlcke , Kurt Van Dijck , Rob Herring , Grant Likely , Colin Cross , Olof Johansson , Richard Purdie , Mark Brown , Mitch Bradley , Mike Frysinger , Eric Miao List-Id: linux-tegra@vger.kernel.org This patch series adds very rudimentary device-tree support for PWM devices. I fully realize that this is early work and it should not be merged as is. However I wanted to post these patches for review to make sure I'm not on a wild-goose chase. With all of these patches applied (plus one board-specific patch that is not included), I'm able to control the backlight on the device I'm working on using the sysfs interface provided by the pwm-backlight driver and the backlight class. This series is based on Sascha Hauer's series of patches[0] to add a generic PWM framework. The first patch in this series is taken from Sascha's branch, while the second patch enables each PWM chip to provide multiple PWM devices (none of the drivers in Sascha's branch are converted yet). When this series is ready I think it would be best to merge patches 1 and 2. Patch 3 adds some code to lookup a PWM chip given its device-tree handle. This code will be used later on by the pwm-backlight driver to find the PWM device that it should be using. Device tree binding documentation is also provided. Patch 4 was taken from the Chromium tree and is required to provide proper clocking of the Tegra2 PWFM controller. All Chromium-specific tags have been removed from the commit message. Patch 5 cleans up the clock registration for Tegra2 because patch 6 will only instantiate one device for the PWFM controller instead of four. Patch 6 adds a generic PWM framework driver for the Tegra2 PWFM controller. The code is taken from the Chromium tree with some adjustments to integrate it with the PWM framework. Patch 7 implements device tree based probing for the Tegra2 PWFM controller. Patches 8 and 9 are ports of the Blackfin PWM and the PXA PWM drivers to the PWM framework. These are only compile-tested as I do not have any hardware to test them on. They are meant as test-bed for the framework. I intend to port other drivers over to the framework for the next spin. Patch 10 implements DT-based probing in the pwm-backlight driver. Note that this code only handles the "pwm" property (by looking up the PWM device via the new PWM DT binding) and the "default-" and "max-brightness" properties. Switching power to the backlight via GPIOs is not supported yet. The whole series is based on the linux-next tree from 20120202. I think I've addressed all of the concerns raised in the first version, and those I haven't yet were still open for discussion (or I've explicitly marked them as TODO). Thierry [0]: http://git.pengutronix.de/?p=imx/linux-2.6.git;a=shortlog;h=refs/heads/pwmlib Sascha Hauer (1): PWM: add pwm framework support Simon Que (1): arm/tegra: Fix PWM clock programming Thierry Reding (8): pwm: Allow chips to support multiple PWMs. of: Add PWM support. arm/tegra: Provide clock for only one PWM controller pwm: Add NVIDIA Tegra SoC support arm/tegra: Add PWFM controller device tree probing pwm: Add Blackfin support pwm: Add PXA support pwm-backlight: Add rudimentary device tree support Documentation/devicetree/bindings/pwm/pwm.txt | 50 +++ .../bindings/video/backlight/pwm-backlight | 16 + Documentation/pwm.txt | 56 +++ MAINTAINERS | 6 + arch/arm/boot/dts/tegra20.dtsi | 6 + arch/arm/boot/dts/tegra30.dtsi | 6 + arch/arm/mach-tegra/board-dt-tegra20.c | 1 + arch/arm/mach-tegra/board-dt-tegra30.c | 1 + arch/arm/mach-tegra/clock.h | 1 + arch/arm/mach-tegra/tegra2_clocks.c | 33 ++- arch/arm/plat-pxa/Makefile | 1 - arch/arm/plat-pxa/pwm.c | 304 ---------------- arch/blackfin/Kconfig | 10 - arch/blackfin/kernel/Makefile | 1 - arch/blackfin/kernel/pwm.c | 100 ------ drivers/Kconfig | 2 + drivers/Makefile | 1 + drivers/of/Kconfig | 6 + drivers/of/Makefile | 1 + drivers/of/pwm.c | 130 +++++++ drivers/pwm/Kconfig | 40 +++ drivers/pwm/Makefile | 4 + drivers/pwm/core.c | 367 ++++++++++++++++++++ drivers/pwm/pwm-bfin.c | 164 +++++++++ drivers/pwm/pwm-pxa.c | 243 +++++++++++++ drivers/pwm/pwm-tegra.c | 266 ++++++++++++++ drivers/video/backlight/Kconfig | 2 +- drivers/video/backlight/pwm_bl.c | 81 ++++- include/linux/of_pwm.h | 51 +++ include/linux/pwm.h | 67 ++++ 30 files changed, 1584 insertions(+), 433 deletions(-) create mode 100644 Documentation/devicetree/bindings/pwm/pwm.txt create mode 100644 Documentation/devicetree/bindings/video/backlight/pwm-backlight create mode 100644 Documentation/pwm.txt delete mode 100644 arch/arm/plat-pxa/pwm.c delete mode 100644 arch/blackfin/kernel/pwm.c create mode 100644 drivers/of/pwm.c create mode 100644 drivers/pwm/Kconfig create mode 100644 drivers/pwm/Makefile create mode 100644 drivers/pwm/core.c create mode 100644 drivers/pwm/pwm-bfin.c create mode 100644 drivers/pwm/pwm-pxa.c create mode 100644 drivers/pwm/pwm-tegra.c create mode 100644 include/linux/of_pwm.h -- 1.7.9 From mboxrd@z Thu Jan 1 00:00:00 1970 From: thierry.reding@avionic-design.de (Thierry Reding) Date: Mon, 6 Feb 2012 16:19:35 +0100 Subject: [PATCH v2 00/10] Add PWM framework and device-tree support. Message-ID: <1328541585-24642-1-git-send-email-thierry.reding@avionic-design.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org This patch series adds very rudimentary device-tree support for PWM devices. I fully realize that this is early work and it should not be merged as is. However I wanted to post these patches for review to make sure I'm not on a wild-goose chase. With all of these patches applied (plus one board-specific patch that is not included), I'm able to control the backlight on the device I'm working on using the sysfs interface provided by the pwm-backlight driver and the backlight class. This series is based on Sascha Hauer's series of patches[0] to add a generic PWM framework. The first patch in this series is taken from Sascha's branch, while the second patch enables each PWM chip to provide multiple PWM devices (none of the drivers in Sascha's branch are converted yet). When this series is ready I think it would be best to merge patches 1 and 2. Patch 3 adds some code to lookup a PWM chip given its device-tree handle. This code will be used later on by the pwm-backlight driver to find the PWM device that it should be using. Device tree binding documentation is also provided. Patch 4 was taken from the Chromium tree and is required to provide proper clocking of the Tegra2 PWFM controller. All Chromium-specific tags have been removed from the commit message. Patch 5 cleans up the clock registration for Tegra2 because patch 6 will only instantiate one device for the PWFM controller instead of four. Patch 6 adds a generic PWM framework driver for the Tegra2 PWFM controller. The code is taken from the Chromium tree with some adjustments to integrate it with the PWM framework. Patch 7 implements device tree based probing for the Tegra2 PWFM controller. Patches 8 and 9 are ports of the Blackfin PWM and the PXA PWM drivers to the PWM framework. These are only compile-tested as I do not have any hardware to test them on. They are meant as test-bed for the framework. I intend to port other drivers over to the framework for the next spin. Patch 10 implements DT-based probing in the pwm-backlight driver. Note that this code only handles the "pwm" property (by looking up the PWM device via the new PWM DT binding) and the "default-" and "max-brightness" properties. Switching power to the backlight via GPIOs is not supported yet. The whole series is based on the linux-next tree from 20120202. I think I've addressed all of the concerns raised in the first version, and those I haven't yet were still open for discussion (or I've explicitly marked them as TODO). Thierry [0]: http://git.pengutronix.de/?p=imx/linux-2.6.git;a=shortlog;h=refs/heads/pwmlib Sascha Hauer (1): PWM: add pwm framework support Simon Que (1): arm/tegra: Fix PWM clock programming Thierry Reding (8): pwm: Allow chips to support multiple PWMs. of: Add PWM support. arm/tegra: Provide clock for only one PWM controller pwm: Add NVIDIA Tegra SoC support arm/tegra: Add PWFM controller device tree probing pwm: Add Blackfin support pwm: Add PXA support pwm-backlight: Add rudimentary device tree support Documentation/devicetree/bindings/pwm/pwm.txt | 50 +++ .../bindings/video/backlight/pwm-backlight | 16 + Documentation/pwm.txt | 56 +++ MAINTAINERS | 6 + arch/arm/boot/dts/tegra20.dtsi | 6 + arch/arm/boot/dts/tegra30.dtsi | 6 + arch/arm/mach-tegra/board-dt-tegra20.c | 1 + arch/arm/mach-tegra/board-dt-tegra30.c | 1 + arch/arm/mach-tegra/clock.h | 1 + arch/arm/mach-tegra/tegra2_clocks.c | 33 ++- arch/arm/plat-pxa/Makefile | 1 - arch/arm/plat-pxa/pwm.c | 304 ---------------- arch/blackfin/Kconfig | 10 - arch/blackfin/kernel/Makefile | 1 - arch/blackfin/kernel/pwm.c | 100 ------ drivers/Kconfig | 2 + drivers/Makefile | 1 + drivers/of/Kconfig | 6 + drivers/of/Makefile | 1 + drivers/of/pwm.c | 130 +++++++ drivers/pwm/Kconfig | 40 +++ drivers/pwm/Makefile | 4 + drivers/pwm/core.c | 367 ++++++++++++++++++++ drivers/pwm/pwm-bfin.c | 164 +++++++++ drivers/pwm/pwm-pxa.c | 243 +++++++++++++ drivers/pwm/pwm-tegra.c | 266 ++++++++++++++ drivers/video/backlight/Kconfig | 2 +- drivers/video/backlight/pwm_bl.c | 81 ++++- include/linux/of_pwm.h | 51 +++ include/linux/pwm.h | 67 ++++ 30 files changed, 1584 insertions(+), 433 deletions(-) create mode 100644 Documentation/devicetree/bindings/pwm/pwm.txt create mode 100644 Documentation/devicetree/bindings/video/backlight/pwm-backlight create mode 100644 Documentation/pwm.txt delete mode 100644 arch/arm/plat-pxa/pwm.c delete mode 100644 arch/blackfin/kernel/pwm.c create mode 100644 drivers/of/pwm.c create mode 100644 drivers/pwm/Kconfig create mode 100644 drivers/pwm/Makefile create mode 100644 drivers/pwm/core.c create mode 100644 drivers/pwm/pwm-bfin.c create mode 100644 drivers/pwm/pwm-pxa.c create mode 100644 drivers/pwm/pwm-tegra.c create mode 100644 include/linux/of_pwm.h -- 1.7.9