From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mga11.intel.com ([192.55.52.93]:3255 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753003Ab2BFQPu (ORCPT ); Mon, 6 Feb 2012 11:15:50 -0500 Subject: Re: [RFC 1/4] iwlwifi: dump stack when fail to gain access to the device From: wwguy To: Stanislaw Gruszka Cc: Intel Linux Wireless , linux-wireless@vger.kernel.org In-Reply-To: <1328544564-8696-1-git-send-email-sgruszka@redhat.com> References: <1328544564-8696-1-git-send-email-sgruszka@redhat.com> Content-Type: text/plain; charset="UTF-8" Date: Mon, 06 Feb 2012 08:08:16 -0800 Message-ID: <1328544496.14547.10.camel@wwguy-ubuntu> (sfid-20120206_171553_868291_8A00AE8C) Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, 2012-02-06 at 17:09 +0100, Stanislaw Gruszka wrote: > Print dump stack when the device is not responding. This should give > some more clue about the reason of failure. Also change the message we > print, since "MAC in deep sleep" is kinda confusing. > > On the way add unlikely(), as fail to gain NIC access is hmm ... > unlikely. > > Signed-off-by: Stanislaw Gruszka > --- > drivers/net/wireless/iwlwifi/iwl-io.c | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/wireless/iwlwifi/iwl-io.c b/drivers/net/wireless/iwlwifi/iwl-io.c > index 83fdff3..ce6d9c1 100644 > --- a/drivers/net/wireless/iwlwifi/iwl-io.c > +++ b/drivers/net/wireless/iwlwifi/iwl-io.c > @@ -120,10 +120,10 @@ int iwl_grab_nic_access_silent(struct iwl_bus *bus) > int iwl_grab_nic_access(struct iwl_bus *bus) > { > int ret = iwl_grab_nic_access_silent(bus); > - if (ret) { > + if (unlikely(ret)) { > u32 val = iwl_read32(bus, CSR_GP_CNTRL); > - IWL_ERR(bus, > - "MAC is in deep sleep!. CSR_GP_CNTRL = 0x%08X\n", val); > + WARN_ONCE(1, "Timeout waiting for ucode processor access " > + "(CSR_GP_CNTRL 0x%08x)\n", val); > } > I agree the message and check make sense, but not sure what new clue we got by doing this? Wey