Re: [PATCH 1/3 v2] mfd: Add LPC driver for Intel ICH chipsets

[Guenter Roeck <guenter.roeck@ericsson.com>]

On Tue, 2012-02-07 at 15:31 -0500, Jean Delvare wrote:
> On Tue, 7 Feb 2012 12:15:17 -0800, Guenter Roeck wrote:
> > Hi Aaron,
> > 
> > On Tue, 2012-02-07 at 14:56 -0500, Aaron Sierra wrote:
> > > This driver currently creates resources for use by a forthcoming ICH
> > > chipset GPIO driver. It could be expanded to created the resources for
> > > converting the esb2rom (mtd) and iTCO_wdt (wdt), and potentially more,
> > > drivers to use the mfd model.
> > > 
> > > Signed-off-by: Aaron Sierra <asierra@xes-inc.com>
> > > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> > > ---
> > 
> > Not sure how to handle this since some of the code is from me ....
> > usually one doesn't add other people's Signed-off unless both are in the
> > commit chain. Comments, anyone ?
> 
> If the code is co-written and you both agree with what the code
> contributed by the other (in terms of Developer's Certificate of
> Origin) then it's IMHO perfectly fine to have two Signed-off-by in the
> submission.
> 
> At any rate it is much better to do that that to commit a known-broken
> patch and have the second contributor fix it afterward.
> 
Ok, makes sense.

Thanks,
Guenter