From: Joe Perches <joe@perches.com>
To: "Rose, Gregory V" <gregory.v.rose@intel.com>
Cc: "Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"gospo@redhat.com" <gospo@redhat.com>,
"sassmann@redhat.com" <sassmann@redhat.com>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: RE: [net 2/8] igb: fix vf lookup
Date: Wed, 08 Feb 2012 15:49:40 -0800 [thread overview]
Message-ID: <1328744980.6909.8.camel@joe2Laptop> (raw)
In-Reply-To: <C5551D9AAB213A418B7FD5E4A6F30A0702F86242@ORSMSX106.amr.corp.intel.com>
On Wed, 2012-02-08 at 23:42 +0000, Rose, Gregory V wrote:
> > diff --git a/drivers/net/ethernet/intel/igb/igb_main.c
[]
> > @@ -5012,7 +5012,8 @@ static int igb_find_enabled_vfs(struct igb_adapter
> > *adapter)
> > vf_devfn = pdev->devfn + 0x80;
> > pvfdev = pci_get_device(hw->vendor_id, device_id, NULL);
> > while (pvfdev) {
> > - if (pvfdev->devfn == vf_devfn)
> > + if (pvfdev->devfn == vf_devfn &&
> > + (pvfdev->bus->number >= pdev->bus->number))
> > vfs_found++;
[]
> I'll fix this one too. You start leaning on checkpatch and you get lazy I guess.
I suppose an indentation rule could be created when
arguments on multiple lines don't align at the open
parenthesis, but I'm not going to rewrite emacs
indentation rules.
Presumably it should only be used with --strict.
Anyone think multiple line tests with inequivalent uses
of parentheses like this one should be noted as well?
next prev parent reply other threads:[~2012-02-08 23:49 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-08 9:36 [net 0/8][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
2012-02-08 9:36 ` [net 1/8] e1000: add dropped DMA receive enable back in for WoL Jeff Kirsher
2012-02-08 9:36 ` [net 2/8] igb: fix vf lookup Jeff Kirsher
2012-02-08 23:42 ` Rose, Gregory V
2012-02-08 23:49 ` Joe Perches [this message]
2012-02-08 23:52 ` David Miller
2012-02-08 23:55 ` Rose, Gregory V
2012-02-09 9:10 ` Jeff Kirsher
2012-02-08 9:36 ` [net 3/8] ixgbe: " Jeff Kirsher
2012-02-08 23:33 ` David Miller
2012-02-08 23:39 ` Rose, Gregory V
2012-02-09 9:06 ` Jeff Kirsher
2012-02-08 9:36 ` [net 4/8] ixgbe: Fix case of Tx Hang in PF with 32 VFs Jeff Kirsher
2012-02-08 9:36 ` [net 5/8] ixgbe: Fix broken dependency on MAX_SKB_FRAGS being related to page size Jeff Kirsher
2012-02-08 9:36 ` [net 6/8] ixgbe: do not update real num queues when netdev is going away Jeff Kirsher
2012-02-08 9:36 ` [net 7/8] ixgbe: dcb: up2tc mapping lost on disable/enable CEE DCB state Jeff Kirsher
2012-02-08 9:36 ` [net 8/8] ixgbe: ethtool: stats user buffer overrun Jeff Kirsher
2012-02-08 15:17 ` Ben Hutchings
2012-02-09 9:34 [net v2 0/8][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
2012-02-09 9:34 ` [net 2/8] igb: fix vf lookup Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1328744980.6909.8.camel@joe2Laptop \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=gregory.v.rose@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
--cc=sassmann@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.