From mboxrd@z Thu Jan  1 00:00:00 1970
From: Luciano Coelho <coelho@ti.com>
Subject: Re: OMAP34xx
Date: Thu, 16 Feb 2012 09:52:19 +0200
Message-ID: <1329378739.5686.22.camel@cumari>
References: <20120208231551.GA9009@kroah.com>
	 <alpine.DEB.2.00.1202081648510.9540@utopia.booyaka.com>
	 <20120209004731.GA11343@kroah.com> <4F3374F0.3080002@bitmer.com>
	 <20120209133739.GB2590@sirena.org.uk> <20120209183624.GJ1426@atomide.com>
	 <1329343056.5686.6.camel@cumari> <87ehtvlkjf.fsf@ti.com>
	 <4F3C4A0E.1000707@deeprootsystems.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Return-path: <linux-omap-owner@vger.kernel.org>
Received: from na3sys009aog120.obsmtp.com ([74.125.149.140]:33793 "EHLO
	na3sys009aog120.obsmtp.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1752278Ab2BPHw1 (ORCPT
	<rfc822;linux-omap@vger.kernel.org>);
	Thu, 16 Feb 2012 02:52:27 -0500
Received: by lahc1 with SMTP id c1so2199063lah.20
        for <linux-omap@vger.kernel.org>; Wed, 15 Feb 2012 23:52:24 -0800 (PST)
In-Reply-To: <4F3C4A0E.1000707@deeprootsystems.com>
Sender: linux-omap-owner@vger.kernel.org
List-Id: linux-omap@vger.kernel.org
To: Kevin Hilman <khilman@deeprootsystems.com>
Cc: Kevin Hilman <khilman@ti.com>, Tony Lindgren <tony@atomide.com>, Mark Brown <broonie@opensource.wolfsonmicro.com>, Jarkko Nikula <jarkko.nikula@bitmer.com>, Greg KH <gregkh@linuxfoundation.org>, Paul Walmsley <paul@pwsan.com>, Grazvydas Ignotas <notasas@gmail.com>, Russell King - ARM Linux <linux@arm.linux.org.uk>, linux-omap@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>

Hi Kevin,

On Wed, 2012-02-15 at 16:13 -0800, Kevin Hilman wrote: 
> On 02/15/2012 03:54 PM, Kevin Hilman wrote:
> > Luciano Coelho<coelho@ti.com>  writes:
> >
> > [...]
> >
> >> I just tried this on my Panda and I keep getting this kind of BUGs.  It
> >> spams my console so much that is pretty much unusable:
> >>
> >> [  336.172302] BUG: sleeping function called from invalid context at include/linux/freezer.h:46
> >> [  336.181213] in_atomic(): 0, irqs_disabled(): 128, pid: 1618, name: ntpd
> >> [  336.181213] INFO: lockdep is turned off.
> >> [  336.181213] irq event stamp: 0
> >> [  336.181213] hardirqs last  enabled at (0): [<   (null)>]   (null)
> >> [  336.201660] hardirqs last disabled at (0): [<c0042314>] copy_process+0x3ec/0x105c
> >> [  336.209625] softirqs last  enabled at (0): [<c0042314>] copy_process+0x3ec/0x105c
> >> [  336.217498] softirqs last disabled at (0): [<   (null)>]   (null)
> >> [  336.217498] [<c001e1e4>] (unwind_backtrace+0x0/0x148) from [<c0502c24>] (dump_stack+0x20/0x24)
> >> [  336.232879] [<c0502c24>] (dump_stack+0x20/0x24) from [<c0077998>] (__might_sleep+0x130/0x134)
> >> [  336.232879] [<c0077998>] (__might_sleep+0x130/0x134) from [<c0018998>] (do_signal+0x54/0x600)
> >> [  336.250793] [<c0018998>] (do_signal+0x54/0x600) from [<c0018fa4>] (do_notify_resume+0x60/0x6c)
> >> [  336.250793] [<c0018fa4>] (do_notify_resume+0x60/0x6c) from [<c00154e4>] (work_pending+0x24/0x28)
> >>
> >> I have also seen this in 3.3-rc3 (both on Panda (OMAP4460) and on Blaze
> >> (OMAP4430) boards) and I was hoping your tree would have the fix for it,
> >> but it doesn't. :( The device boots and seems to work otherwise, but
> >> this is annoying and looks shaky.
> >>
> >> I saw something related to this in another thread from a few months ago,
> >> and one patch proposal by Russell, but I didn't find any conclusion or
> >> any related patch queued up for upstream.
> >>
> >> Is there any solution for this? I use a tuned .config (attached) and not
> >> the one generated by omap2plus_defconfig (which I didn't try as
> >> vanilla).
> >
> > I see the same thing with your ~/.config, but I don't think this is OMAP
> > specific.  I suspect this will happen on any ARM platform that  has
> > CONFIG_DEBUG_ATOMIC_SLEEP=y.

Right.  I always use CONFIG_DEBUG_ATOMIC_SLEEP.  And yes, according to
what I had seen, this was an ARM issue not only OMAP.


> > It appears to be a problem with the recently added audit support for
> > ARM, since reverting the commit below makes this BUG go away.
> 
> False alarm.  reverting the audit commit didn't make the problem go 
> away.  It was gone only because I also disabled 
> CONFIG_DEBUG_ATOMIC_SLEEP.  :/
> 
> To debug this further, you might bisect it back to v3.2 because the 
> problem isn't there in v3.2

When I was looking a bit further, I found this patch: a0acae0e "freezer:
unexport refrigerator() and update try_to_freeze() slightly", which
seems to be the one introducing the bug.  It's quite far back and quite
large, so reverting it is not that easy.

I may try to do some bisecting later today, but I'm not sure I'll have
the time.

-- 
Cheers,
Luca.