From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from he.sipsolutions.net ([78.46.109.217]:34890 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751470Ab2BPOjJ (ORCPT ); Thu, 16 Feb 2012 09:39:09 -0500 Subject: Re: calling request_firmware() from module init will not work with recent/future udev versions From: Johannes Berg To: Arend van Spriel Cc: Kay Sievers , "netdev@vger.kernel.org" , "linux-wireless@vger.kernel.org" , Tom Gundersen , Andy Whitcroft In-Reply-To: <4F3D0012.9070808@broadcom.com> References: <1326621743.3448.1.camel@jlt3.sipsolutions.net> ( sfid-20120115_163411_716244_29DE7A13) <1326704259.3510.3.camel@jlt3.sipsolutions.net> <4F3CF0C1.3090304@broadcom.com> <1329395881.3915.7.camel@jlt3.sipsolutions.net> <4F3D0012.9070808@broadcom.com> Content-Type: text/plain; charset="UTF-8" Date: Thu, 16 Feb 2012 15:39:05 +0100 Message-ID: <1329403145.3915.10.camel@jlt3.sipsolutions.net> (sfid-20120216_153921_586251_AA7D60E4) Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Thu, 2012-02-16 at 14:09 +0100, Arend van Spriel wrote: > > When the firmware loading fails, the driver should unbind from the > > device that it failed for, and the retrying behaviour doesn't change > > (and requires a rebind) > That helps. My driver was happily bound to the device until unloading > the driver or unplugging the device. Right, if it fails you should call device_release_driver() johannes From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Berg Subject: Re: calling request_firmware() from module init will not work with recent/future udev versions Date: Thu, 16 Feb 2012 15:39:05 +0100 Message-ID: <1329403145.3915.10.camel@jlt3.sipsolutions.net> References: <1326621743.3448.1.camel@jlt3.sipsolutions.net> ( sfid-20120115_163411_716244_29DE7A13) <1326704259.3510.3.camel@jlt3.sipsolutions.net> <4F3CF0C1.3090304@broadcom.com> <1329395881.3915.7.camel@jlt3.sipsolutions.net> <4F3D0012.9070808@broadcom.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: Kay Sievers , "netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Tom Gundersen , Andy Whitcroft To: Arend van Spriel Return-path: In-Reply-To: <4F3D0012.9070808-dY08KVG/lbpWk0Htik3J/w@public.gmane.org> Sender: linux-wireless-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org On Thu, 2012-02-16 at 14:09 +0100, Arend van Spriel wrote: > > When the firmware loading fails, the driver should unbind from the > > device that it failed for, and the retrying behaviour doesn't change > > (and requires a rebind) > That helps. My driver was happily bound to the device until unloading > the driver or unplugging the device. Right, if it fails you should call device_release_driver() johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html