All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Vagin <avagin@openvz.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org, avagin@openvz.org,
	Ingo Molnar <mingo@redhat.com>,
	Frederic Weisbecker <fweisbec@gmail.com>
Subject: [PATCH] Re: [PATCH] trace: don't print an extra separator of flags
Date: Mon, 20 Feb 2012 23:43:30 +0300	[thread overview]
Message-ID: <1329770610-703006-1-git-send-email-avagin@openvz.org> (raw)
In-Reply-To: <1329767276.25686.40.camel@gandalf.stny.rr.com>

> Could you send me that patch. Or a change to the kernel that shows the
> problemi.

Without my patch:
    event-sample-1731  [000] ...1 546886.253576: foo_bar: foo hello 3 |A B
    event-sample-1731  [000] ...1 546887.253677: foo_bar: foo hello 4 |A B

With my patch:
    event-sample-1731  [000] ...1 546886.253576: foo_bar: foo hello 3 A B
    event-sample-1731  [000] ...1 546887.253677: foo_bar: foo hello 4 A B


---
 samples/trace_events/trace-events-sample.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/samples/trace_events/trace-events-sample.h b/samples/trace_events/trace-events-sample.h
index 6af3732..812be4b 100644
--- a/samples/trace_events/trace-events-sample.h
+++ b/samples/trace_events/trace-events-sample.h
@@ -90,7 +90,7 @@ TRACE_EVENT(foo_bar,
 		__entry->bar	= bar;
 	),
 
-	TP_printk("foo %s %d", __entry->foo, __entry->bar)
+	TP_printk("foo %s %d %s %s", __entry->foo, __entry->bar, __print_flags(1, "|", {1, "A"}), __print_flags(2, "&", {2, "B"}))
 );
 #endif
 
-- 
1.7.1


  reply	other threads:[~2012-02-20 20:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-19 11:16 [PATCH] trace: don't print an extra separator of flags Andrew Vagin
2012-02-20 18:09 ` Steven Rostedt
2012-02-20 19:39   ` avagin
2012-02-20 19:47     ` Steven Rostedt
2012-02-20 20:43       ` Andrew Vagin [this message]
2012-02-21  1:18         ` [PATCH] " Steven Rostedt
2012-02-27  9:31 ` [tip:perf/core] tracing: Don't " tip-bot for Andrey Vagin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1329770610-703006-1-git-send-email-avagin@openvz.org \
    --to=avagin@openvz.org \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.