From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752599Ab2B0Ncj (ORCPT ); Mon, 27 Feb 2012 08:32:39 -0500 Received: from mail-pz0-f46.google.com ([209.85.210.46]:40631 "EHLO mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751862Ab2B0Nci (ORCPT ); Mon, 27 Feb 2012 08:32:38 -0500 Authentication-Results: mr.google.com; spf=pass (google.com: domain of namhyung@gmail.com designates 10.68.213.232 as permitted sender) smtp.mail=namhyung@gmail.com; dkim=pass header.i=namhyung@gmail.com Subject: Re: [PATCH] hw breakpoint: Fix possible memory leak From: Namhyung Kim To: Ingo Molnar Cc: Peter Zijlstra , Namhyung Kim , Paul Mackerras , Arnaldo Carvalho de Melo , LKML , Frederic Weisbecker In-Reply-To: <20120227115652.GA9943@elte.hu> References: <1330311739-24302-1-git-send-email-namhyung.kim@lge.com> <1330338785.11248.49.camel@twins> <20120227104452.GA6082@elte.hu> <1330340694.11248.64.camel@twins> <20120227115652.GA9943@elte.hu> Content-Type: text/plain; charset="UTF-8" Date: Mon, 27 Feb 2012 22:32:31 +0900 Message-ID: <1330349551.1782.15.camel@leonhard> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2012-02-27 (월), 12:56 +0100, Ingo Molnar: > * Peter Zijlstra wrote: > > > On Mon, 2012-02-27 at 11:44 +0100, Ingo Molnar wrote: > > > I edited that code earlier today - is the form below OK, or can > > > you see a simpler method? It's not yet pushed out so can still > > > edit it. > > > > I think something like the below should do, but then I didn't really > > think much about it, my thoughts went like: > > > > ... *shees* that's ugly > > ... that error path already does a loop > > ... what the problem is!? -- reread changelog > > ... err_cpu == cpu is placed wrong! > > > > > > So I replied and marked read.. waiting to either hear if there's a good > > reason to do ugly or find a new (tested) patch in my inbox.. :-) > > > > --- > > kernel/events/hw_breakpoint.c | 4 ++-- > > 1 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/kernel/events/hw_breakpoint.c b/kernel/events/hw_breakpoint.c > > index b0309f7..3330022 100644 > > --- a/kernel/events/hw_breakpoint.c > > +++ b/kernel/events/hw_breakpoint.c > > @@ -658,10 +658,10 @@ int __init init_hw_breakpoint(void) > > > > err_alloc: > > for_each_possible_cpu(err_cpu) { > > - if (err_cpu == cpu) > > - break; > > for (i = 0; i < TYPE_MAX; i++) > > kfree(per_cpu(nr_task_bp_pinned[i], cpu)); > > + if (err_cpu == cpu) > > + break; > > } > > Looks a lot nicer - I'll wait for an updated patch. > > Thanks, > > Ingo Ingo, do you want me to resend? If so, I really don't know how to give the credit to Peter in this case. Or will you take the patch from him directly? -- Regards, Namhyung Kim