From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965176Ab2B1LK1 (ORCPT ); Tue, 28 Feb 2012 06:10:27 -0500 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:56771 "EHLO opensource.wolfsonmicro.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757049Ab2B1LK0 (ORCPT ); Tue, 28 Feb 2012 06:10:26 -0500 From: Mark Brown To: Steven Rostedt , Frederic Weisbecker , Ingo Molnar , Jiri Olsa Cc: linux-kernel@vger.kernel.org, Mark Brown Subject: [PATCH] trace: Fix build breakage without CONFIG_PERF_EVENTS Date: Tue, 28 Feb 2012 11:10:23 +0000 Message-Id: <1330427423-25499-1-git-send-email-broonie@opensource.wolfsonmicro.com> X-Mailer: git-send-email 1.7.9.1 In-Reply-To: <1330426967-17067-1-git-send-email-broonie@opensource.wolfsonmicro.com> References: <1330426967-17067-1-git-send-email-broonie@opensource.wolfsonmicro.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Today's -next fails to build for me: CC kernel/trace/trace_export.o In file included from kernel/trace/trace_export.c:197: kernel/trace/trace_entries.h:58: error: 'perf_ftrace_event_register' undeclared here (not in a function) make[2]: *** [kernel/trace/trace_export.o] Error 1 make[1]: *** [kernel/trace] Error 2 make: *** [kernel] Error 2 because as of ced390 (ftrace, perf: Add support to use function tracepoint in perf) perf_trace_event_register() is declared in trace.h only if CONFIG_PERF_EVENTS is enabled but I don't have that set. Ensure that we always have a definition of perf_trace_event_register() by providing a definition if CONFIG_PERF_EVENTS is disabled. Signed-off-by: Mark Brown --- This one had the build test run all the way... kernel/trace/trace.h | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/kernel/trace/trace.h b/kernel/trace/trace.h index 54faec7..2aef24e 100644 --- a/kernel/trace/trace.h +++ b/kernel/trace/trace.h @@ -842,6 +842,8 @@ int perf_ftrace_event_register(struct ftrace_event_call *call, #else #define perf_ftrace_event_register NULL #endif /* CONFIG_FUNCTION_TRACER */ +#else +#define perf_ftrace_event_register NULL #endif /* CONFIG_PERF_EVENTS */ #endif /* _LINUX_KERNEL_TRACE_H */ -- 1.7.9.1