From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B57A0C3A5A9 for ; Sat, 2 May 2020 13:08:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9B266216FD for ; Sat, 2 May 2020 13:08:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728011AbgEBNI6 (ORCPT ); Sat, 2 May 2020 09:08:58 -0400 Received: from mail.secom.com.pl ([213.216.87.26]:44139 "EHLO mail.secom.com.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727880AbgEBNI6 (ORCPT ); Sat, 2 May 2020 09:08:58 -0400 Received: from [192.168.1.110] (host-85.14.70.3.static.3s.pl [85.14.70.3]) by mail.secom.com.pl; Sat, 02 May 2020 15:08:20 +0200 Subject: Re: [PATCH] dma: zynqmp_dma: Initialize descriptor list after freeing during reset To: Vinod Koul Cc: Appana Durga Kedareswara rao , Radhey Shyam Pandey , Harini Katakam , Dan Williams , Michal Simek , "open list:DMA GENERIC OFFLOAD ENGINE SUBSYSTEM" , "moderated list:ARM/ZYNQ ARCHITECTURE" , open list References: <20200428143225.3357-1-rafal.hibner@secom.com.pl> <20200502123242.GB1375924@vkoul-mobl> From: =?UTF-8?Q?Rafa=c5=82_Hibner?= Message-ID: <1330934e-342e-1e16-6451-d8952463119c@secom.com.pl> Date: Sat, 2 May 2020 15:00:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: <20200502123242.GB1375924@vkoul-mobl> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Vinod, On 02.05.2020 14:32, Vinod Koul wrote: > Would it not be better to use list_del_init() where we delete it rather > than do the init here? > It is not a problem of list element itself not being initialized. The problem is that during fault conditions (zynqmp_dma_reset) all elements are moved to free list. List head however is not reinitialized. In normal flow elements are removed by list_del and resubmitted to free list with zynqmp_dma_free_descriptor. static void zynqmp_dma_chan_desc_cleanup(struct zynqmp_dma_chan *chan) {     ...     list_for_each_entry_safe(desc, next, &chan->done_list, node) {         ...         list_del(&desc->node);         ...         zynqmp_dma_free_descriptor(chan, desc);     } } The zynqmp_dma_free_descriptor does not delete elements from the list by itself. I am not he author of this driver so I fixed it by doing non intrusive changes. Anyways, I do not see how using list_del_init would fix the bug. Regards, Rafal From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C35EC3A5A9 for ; Sat, 2 May 2020 13:09:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3FB7E2184D for ; Sat, 2 May 2020 13:09:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WHuhB7Nt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3FB7E2184D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=secom.com.pl Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=U7RJfi+KysxhJ9VP7j4FeV/LSFAq51R06VqgMffPSlY=; b=WHuhB7NtKAyQuI bBxOlolCq3C38x337hDEHak3N5OPEj8WWngQGSNK3laJtDkBmnQnbjMx2IzhR36M+9hEvv52Vc72z XJRxeOQSx7+Kg3PWtWIZ3Y/gbZsJa3EPK0LcZKe1keI2A2n0QtMckc+on0C1HF6foPVzZloz2ZhP4 P9SMRFAGhsjsR2+J5KpjlpE/1AECBgEwM7lpmR4rmqG0OGLCHM56KJNmFEl0SXvPR2UWUEfJ22T55 SfUX7NKzGoDsW1Fb+gGS8ywn/vUCv5HiJVqLCiidF31jgs3u/BdifN57SGW0e+bJvMn52HDC2Ojf3 e49D6VfP3UQh9qVZEwhA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jUrt3-0002g3-BS; Sat, 02 May 2020 13:08:57 +0000 Received: from mail.secom.com.pl ([213.216.87.26]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jUrt0-0002fM-IG for linux-arm-kernel@lists.infradead.org; Sat, 02 May 2020 13:08:56 +0000 Received: from [192.168.1.110] (host-85.14.70.3.static.3s.pl [85.14.70.3]) by mail.secom.com.pl; Sat, 02 May 2020 15:08:20 +0200 Subject: Re: [PATCH] dma: zynqmp_dma: Initialize descriptor list after freeing during reset To: Vinod Koul References: <20200428143225.3357-1-rafal.hibner@secom.com.pl> <20200502123242.GB1375924@vkoul-mobl> From: =?UTF-8?Q?Rafa=c5=82_Hibner?= Message-ID: <1330934e-342e-1e16-6451-d8952463119c@secom.com.pl> Date: Sat, 2 May 2020 15:00:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: <20200502123242.GB1375924@vkoul-mobl> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200502_060854_942065_D03F399F X-CRM114-Status: UNSURE ( 8.47 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Radhey Shyam Pandey , Michal Simek , open list , Appana Durga Kedareswara rao , "open list:DMA GENERIC OFFLOAD ENGINE SUBSYSTEM" , Harini Katakam , Dan Williams , "moderated list:ARM/ZYNQ ARCHITECTURE" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGVsbG8gVmlub2QsCgpPbiAwMi4wNS4yMDIwIDE0OjMyLCBWaW5vZCBLb3VsIHdyb3RlOgo+IFdv dWxkIGl0IG5vdCBiZSBiZXR0ZXIgdG8gdXNlIGxpc3RfZGVsX2luaXQoKSB3aGVyZSB3ZSBkZWxl dGUgaXQgcmF0aGVyCj4gdGhhbiBkbyB0aGUgaW5pdCBoZXJlPwo+CgpJdCBpcyBub3QgYSBwcm9i bGVtIG9mIGxpc3QgZWxlbWVudCBpdHNlbGYgbm90IGJlaW5nIGluaXRpYWxpemVkLgpUaGUgcHJv YmxlbSBpcyB0aGF0IGR1cmluZyBmYXVsdCBjb25kaXRpb25zICh6eW5xbXBfZG1hX3Jlc2V0KSBh bGwKZWxlbWVudHMgYXJlIG1vdmVkIHRvIGZyZWUgbGlzdC4gTGlzdCBoZWFkIGhvd2V2ZXIgaXMg bm90IHJlaW5pdGlhbGl6ZWQuCgpJbiBub3JtYWwgZmxvdyBlbGVtZW50cyBhcmUgcmVtb3ZlZCBi eSBsaXN0X2RlbCBhbmQgcmVzdWJtaXR0ZWQgdG8KZnJlZSBsaXN0IHdpdGggenlucW1wX2RtYV9m cmVlX2Rlc2NyaXB0b3IuCgpzdGF0aWMgdm9pZCB6eW5xbXBfZG1hX2NoYW5fZGVzY19jbGVhbnVw KHN0cnVjdCB6eW5xbXBfZG1hX2NoYW4gKmNoYW4pCnsKwqDCoMKgIC4uLgrCoMKgwqAgbGlzdF9m b3JfZWFjaF9lbnRyeV9zYWZlKGRlc2MsIG5leHQsICZjaGFuLT5kb25lX2xpc3QsIG5vZGUpIHsK wqDCoMKgwqDCoMKgwqAgLi4uCsKgwqDCoMKgwqDCoMKgIGxpc3RfZGVsKCZkZXNjLT5ub2RlKTsK wqDCoMKgwqDCoMKgwqAgLi4uCsKgwqDCoMKgwqDCoMKgIHp5bnFtcF9kbWFfZnJlZV9kZXNjcmlw dG9yKGNoYW4sIGRlc2MpOwrCoMKgwqAgfQp9CgpUaGUgenlucW1wX2RtYV9mcmVlX2Rlc2NyaXB0 b3IgZG9lcyBub3QgZGVsZXRlIGVsZW1lbnRzIGZyb20gdGhlCmxpc3QgYnkgaXRzZWxmLgpJIGFt IG5vdCBoZSBhdXRob3Igb2YgdGhpcyBkcml2ZXIgc28gSSBmaXhlZCBpdCBieQpkb2luZyBub24g aW50cnVzaXZlIGNoYW5nZXMuCgpBbnl3YXlzLCBJIGRvIG5vdCBzZWUgaG93IHVzaW5nIGxpc3Rf ZGVsX2luaXQgd291bGQgZml4IHRoZSBidWcuCgpSZWdhcmRzLCBSYWZhbAoKCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFp bGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlz dHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK