From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:44613)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gxt@mprc.pku.edu.cn>) id 1S7z6x-0004MN-TM
	for qemu-devel@nongnu.org; Wed, 14 Mar 2012 21:04:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <gxt@mprc.pku.edu.cn>) id 1S7z6v-0005iE-To
	for qemu-devel@nongnu.org; Wed, 14 Mar 2012 21:04:11 -0400
Received: from mprc.pku.edu.cn ([162.105.203.9]:40095)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gxt@mprc.pku.edu.cn>) id 1S7z6v-0005gc-7h
	for qemu-devel@nongnu.org; Wed, 14 Mar 2012 21:04:09 -0400
Message-ID: <1331773493.2389.62.camel@epip-laptop>
From: Guan Xuetao <gxt@mprc.pku.edu.cn>
Date: Thu, 15 Mar 2012 09:04:53 +0800
In-Reply-To: <4F607961.2000509@suse.de>
References: <1330893156-26569-1-git-send-email-afaerber@suse.de>
	<1331689198-11076-1-git-send-email-afaerber@suse.de>
	<1331689198-11076-4-git-send-email-afaerber@suse.de>
	<1331711792.2389.29.camel@epip-laptop> <4F607961.2000509@suse.de>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 3/7] target-unicore32: QOM'ify CPU
Reply-To: gxt@mprc.pku.edu.cn
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andreas =?ISO-8859-1?Q?F=E4rber?= <afaerber@suse.de>
Cc: qemu-devel@nongnu.org

On Wed, 2012-03-14 at 11:56 +0100, Andreas F=C3=A4rber wrote:
> Am 14.03.2012 08:56, schrieb Guan Xuetao:
> > On Wed, 2012-03-14 at 02:39 +0100, Andreas F=C3=A4rber wrote:
> >> Embed CPUUniCore32State into UniCore32CPU.
> >>
> >> Contributed under GPLv2+.
> >>
> >> Signed-off-by: Andreas F=C3=A4rber <afaerber@suse.de>
> >> ---
> >>  Makefile.target            |    1 +
> >>  target-unicore32/cpu-qom.h |   72 +++++++++++++++++++++++++++++++++=
+
> >>  target-unicore32/cpu.c     |   91 +++++++++++++++++++++++++++++++++=
+++++++++++
> > I hope the gpl information for cpu.c and cpu-qom.h could be consisten=
t
> > with other files.
>=20
> Copy&paste from other cpu-qom.h files. :) I can change it to match the
> rest of target-unicore32.
>=20
> But speaking of matching licenses, your previous text has "as published
> by the Free Software Foundation", which I think is a bit safer in theor=
y
> (no company X can publish a "GPL" v4 of their own and change it to thei=
r
> liking) and would make the change smaller. For example:
>=20
>   * This program is free software; you can redistribute it and/or modif=
y
>   * it under the terms of the GNU General Public License version 2 as
> - * published by the Free Software Foundation.
> + * published by the Free Software Foundation, or (at your option) any
> + * later version. See the COPYING file in the top-level directory.
>=20
> What do you think?
>=20
> Andreas
>=20
GPLv2+ is ok.

Thanks and Regards

Guan Xuetao