All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Paris <eparis@redhat.com>
To: Luis Henriques <henrix@camandro.org>
Cc: Lino Sanfilippo <LinoSanfilippo@gmx.de>,
	viro@ZenIV.linux.org.uk, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 0/9] fsnotify: change locking order
Date: Tue, 20 Mar 2012 14:58:19 -0400	[thread overview]
Message-ID: <1332269899.3178.3.camel@localhost> (raw)
In-Reply-To: <87fwd3glak.fsf@camandro.org>

I'm pretty sure it stalled on me.  I pushed his work to my tree months
and months ago and never sent it along to Linus.  I'll try to make sure
to do that this window.

-Eric

On Tue, 2012-03-20 at 18:49 +0000, Luis Henriques wrote:
> Hi Lino,
> 
> Lino Sanfilippo <LinoSanfilippo@gmx.de> writes:
> 
> > On Mon, Aug 01, 2011 at 04:38:22PM -0400, Eric Paris wrote:
> ...
> >> 
> >> Looks at aweful lot like the problem from:
> >> http://www.spinics.net/lists/linux-fsdevel/msg46101.html
> >> 
> >
> > I tried to reproduce this bug with your test program, but without success.
> > However, if I understand correctly, this occurs since we dont hold any locks when
> > we call iput() in mark_destroy(), right?
> > With the patches you tested, iput() is also not called within any lock, since the
> > groups mark_mutex is released temporarily before iput() is called.  This is, since
> > the original codes behaviour is similar.
> > However since we now have a mutex as the biggest lock, we can do what you 
> > suggested (http://www.spinics.net/lists/linux-fsdevel/msg46107.html) and 
> > call iput() with the mutex held to avoid the race.
> > The patch below implements this. It uses nested locking to avoid deadlock in case
> > we do the final iput() on an inode which still holds marks and thus would take
> > the mutex again when calling fsnotify_inode_delete() in destroy_inode().
> 
> I know it's been a while since you posted this series, but I was
> wondering if there has been any progress.  Is there anyone working on
> this, or is it stalled?
> 
> Cheers,
> --
> Luis



  reply	other threads:[~2012-03-20 18:58 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-14 15:29 [PATCH 0/9] fsnotify: change locking order Lino Sanfilippo
2011-06-14 15:29 ` [PATCH 1/9] inotify, fanotify: replace fsnotify_put_group() with fsnotify_destroy_group() Lino Sanfilippo
2011-06-14 15:29 ` [PATCH 2/9] fsnotify: introduce fsnotify_get_group() Lino Sanfilippo
2011-06-14 15:29 ` [PATCH 3/9] fsnotify: use reference counting for groups Lino Sanfilippo
2011-06-14 15:29 ` [PATCH 4/9] fsnotify: take groups mark_lock before mark lock Lino Sanfilippo
2011-06-14 15:29 ` [PATCH 5/9] fanotify: add an extra flag to mark_remove_from_mask that indicates wheather a mark should be destroyed Lino Sanfilippo
2011-06-14 15:29 ` [PATCH 6/9] fsnotify: use a mutex instead of a spinlock to protect a groups mark list Lino Sanfilippo
2011-06-14 15:29 ` [PATCH 7/9] fsnotify: pass group to fsnotify_destroy_mark() Lino Sanfilippo
2011-06-14 15:29 ` [PATCH 8/9] fsnotify: introduce locked versions of fsnotify_add_mark() and fsnotify_remove_mark() Lino Sanfilippo
2011-06-14 15:29 ` [PATCH 9/9] fsnotify: dont put marks on temporary list when clearing marks by group Lino Sanfilippo
2011-08-01 20:38 ` [PATCH 0/9] fsnotify: change locking order Eric Paris
2011-08-11 23:13   ` Lino Sanfilippo
2012-03-20 18:49     ` Luis Henriques
2012-03-20 18:58       ` Eric Paris [this message]
2012-03-20 19:05         ` Luis Henriques
2012-03-22 22:14         ` Lino Sanfilippo
2012-03-26 11:27         ` Luis Henriques
2012-03-26 15:12           ` Eric Paris
2012-03-26 15:27             ` Luis Henriques
2012-03-26 22:51               ` Lino Sanfilippo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1332269899.3178.3.camel@localhost \
    --to=eparis@redhat.com \
    --cc=LinoSanfilippo@gmx.de \
    --cc=henrix@camandro.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.