From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BE31C433F5 for ; Mon, 13 Sep 2021 12:13:09 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 156C260F9B for ; Mon, 13 Sep 2021 12:13:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 156C260F9B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 47B8583A64; Mon, 13 Sep 2021 14:13:05 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1631535185; bh=80Y1wMv/SxH77KkTFmrwJzv6JHUYFsosN3Yq3Y2cLRE=; h=To:cc:From:Subject:In-reply-to:References:Date:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=PZyTj+q4EwFNFBpgo5K8AvEVeb8W73fl4bKnUSAJHWLGaRI4S7ulVnU/DUVkpvPIm LrWXIfspBeEV6r1mcbjl1xKnljaMqrr1WaXR38KHJpgbmfmJ08lJMiJ7IPsQG16Z+J 4QCDilTO0rJ1mCSTiCZD1y4oVZIoPUVnvpoOfWIclNyvkuS4zENkuUZYsLO5v1Vel0 JV1eKBTa3H3JdU6YTu9wjv1Ese+b1qdP1B6kUmRpHwVUoXGo+k+6aYnvqwfMb17IN/ uPLb2cgvniwQzzeueJKvLXeeY8K5bejVCLDDf6iDTnLty3hSVP5xIzsbG3eNHVimc/ vG/+Dak3oMqzA== Received: from janitor.denx.de (unknown [62.91.23.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: noc@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id EDA2083A59 for ; Mon, 13 Sep 2021 14:13:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1631535183; bh=80Y1wMv/SxH77KkTFmrwJzv6JHUYFsosN3Yq3Y2cLRE=; h=To:cc:From:Subject:In-reply-to:References:Date:From; b=YRwIcrdAzCQG23xGL9ZwD1f5zMVOw+v25WqsiG7Ky5FWFUCRAElftxA0KNjKJG5Z/ LeRBLPIpiov6RWsfr7XsvKwHMSOWcvhxTeUvfoslFBYQ2OMLTCj53qexi+dC0TDlOp LxFEws4i1hlLsycQduzlPOrfT1zFV7nFUUIcdsrju7nSjMPc5QTC3GvAfNAU200Pdc 53OIHY23jA2o/HVSIV2rtcDMXtEM3kNQKFNCdokISODDESFGq3z9R+WjJUVWJ3PEGA WQkff3a17CjjxTeSHaPS4smmyBNQ0WMs2SCBtxytSFNCLWL0X4RqspcN1nmRVobj+j /xrgJESgRgpow== Received: by janitor.denx.de (Postfix, from userid 108) id 9EB8FA0126; Mon, 13 Sep 2021 14:13:02 +0200 (CEST) Received: from gemini.denx.de (gemini.denx.de [10.4.0.2]) by janitor.denx.de (Postfix) with ESMTPS id 5F5F7A0036; Mon, 13 Sep 2021 14:12:54 +0200 (CEST) Received: from gemini.denx.de (localhost [IPv6:::1]) by gemini.denx.de (Postfix) with ESMTP id 4E7951E0AE8; Mon, 13 Sep 2021 14:12:54 +0200 (CEST) To: Pali =?utf-8?B?Um9ow6Fy?= cc: Simon Glass , Heinrich Schuchardt , u-boot@lists.denx.de From: Wolfgang Denk Subject: Re: [PATCH 1/2] xyz-modem: Wait infinitely for initial y-modem packet MIME-Version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 8bit In-reply-to: <20210913110806.27hc36n6gmhw6uq4@pali> References: <20210910204653.3066-1-pali@kernel.org> <1325940.1631529762@gemini.denx.de> <20210913110806.27hc36n6gmhw6uq4@pali> Comments: In-reply-to Pali =?utf-8?B?Um9ow6Fy?= message dated "Mon, 13 Sep 2021 13:08:06 +0200." Date: Mon, 13 Sep 2021 14:12:54 +0200 Message-ID: <1332387.1631535174@gemini.denx.de> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Dear Pali Rohár, In message <20210913110806.27hc36n6gmhw6uq4@pali> you wrote: > > > If you use loady in any kind of scripts, this would now hard hang > > the system, while until now it was possible to recover from the > > error. > > Yes, this is a good point. But on the other hand, 'loadb' and 'loads' > commands already have this behavior. So question is if it is better to > have same behavior in all 'load?' commands or each 'load?' would behave > differently... Because for software which transmit files and supports > more protocols (e.g. both x-modem and kermit) it may be a nightmare if > receiver behaves differently... Yes, you are right, there is an unlucky difference in behaviour. But all these interfaces are pretty old, and I would not invest efforts to fix a aproblem nobody ever noticed before, at the risk of breaking existing stuff. I wonder if there are any users of 'loads' left - the Motorola S-record format is close to 50 years old and cumbersome to use. I can't even remeber when I used it the last time - must be 15+ years or such. 'loadb" is a different thing, but there you usually have kermit on the other side, and usually run an interactive session (or an automated one using something like tbot ) - in any case, you normally have to interact on both sides. I never had a problem wih the current behaviour there. > If you do not have integrated y-modem support in your terminal you have > to do: > > 1) open terminal and write 'loady' into U-Boot console > 2) disconnect terminal > 3) start y-modem software > 4) choose file to transmit > 5) instruct y-modem software to start transfer > > And if 'loady' timeouts between 2) - 5) then it returns back to the If this happens, the timeout is inconveniently short of you are too slow. I think what would be helpful is to make the timeout adjustable (env var). > So... I do not know what is better if current behavior or this new which > changes UI interaction. We can do both, and still solve your problem: make the timeout adjustable so you can set it to something you can conveniently work with. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de "I can call spirits from the vasty deep." "Why so can I, or so can any man; but will they come when you do call for them?" - Shakespeare, 1 King Henry IV, Act III, Scene I.