All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Benoît Canet" <benoit.canet@gmail.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, pbonzini@redhat.com,
	"Benoît Canet" <benoit.canet@gmail.com>,
	stefanha@linux.vnet.ibm.com
Subject: [Qemu-devel] [PATCH V3 6/7] qed: honor BDRV_O_INCOMING for incoming live migration
Date: Fri, 23 Mar 2012 08:36:53 +0100	[thread overview]
Message-ID: <1332488214-4685-7-git-send-email-benoit.canet@gmail.com> (raw)
In-Reply-To: <1332488214-4685-1-git-send-email-benoit.canet@gmail.com>

>From original commit with Patchwork-id: 31108 by
Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>

"The QED image format includes a file header bit to mark images dirty.
QED normally checks dirty images on open and fixes inconsistent
metadata.  This is undesirable during live migration since the dirty bit
may be set if the source host is modifying the image file.  The check
should be postponed until migration completes.

Skip operations that modify the image file if the BDRV_O_INCOMING flag
is set."

Signed-off-by: Benoit Canet <benoit.canet@gmail.com>
---
 block/qed.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/block/qed.c b/block/qed.c
index e32f598..4a53db6 100644
--- a/block/qed.c
+++ b/block/qed.c
@@ -450,7 +450,7 @@ static int bdrv_qed_open(BlockDriverState *bs, int flags)
      * feature is no longer valid.
      */
     if ((s->header.autoclear_features & ~QED_AUTOCLEAR_FEATURE_MASK) != 0 &&
-        !bdrv_is_read_only(bs->file)) {
+        !bdrv_is_read_only(bs->file) && !(flags & BDRV_O_INCOMING)) {
         s->header.autoclear_features &= QED_AUTOCLEAR_FEATURE_MASK;
 
         ret = qed_write_header_sync(s);
@@ -477,7 +477,8 @@ static int bdrv_qed_open(BlockDriverState *bs, int flags)
          * potentially inconsistent images to be opened read-only.  This can
          * aid data recovery from an otherwise inconsistent image.
          */
-        if (!bdrv_is_read_only(bs->file)) {
+        if (!bdrv_is_read_only(bs->file) &&
+            !(flags & BDRV_O_INCOMING)) {
             BdrvCheckResult result = {0};
 
             ret = qed_check(s, &result, true);
-- 
1.7.7.6

  parent reply	other threads:[~2012-03-23  7:37 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-23  7:36 [Qemu-devel] [PATCH V3 0/7] Make QED with live migration safe Benoît Canet
2012-03-23  7:36 ` [Qemu-devel] [PATCH V3 1/7] block: Add new BDRV_O_INCOMING flag to notice incoming live migration Benoît Canet
2012-03-23  7:36 ` [Qemu-devel] [PATCH V3 2/7] block: add a function to clear incoming live migration flags Benoît Canet
2012-03-23  7:36 ` [Qemu-devel] [PATCH V3 3/7] blockdev: open images with BDRV_O_INCOMING on incoming live migration Benoît Canet
2012-03-23  7:36 ` [Qemu-devel] [PATCH V3 4/7] qed: add bdrv_invalidate_cache to be called after " Benoît Canet
2012-03-23  7:36 ` [Qemu-devel] [PATCH V3 5/7] migration: clear BDRV_O_INCOMING flags on end of " Benoît Canet
2012-03-23  7:36 ` Benoît Canet [this message]
2012-03-23  7:36 ` [Qemu-devel] [PATCH V3 7/7] qed: remove incoming live migration blocker Benoît Canet
2012-03-23 11:24 ` [Qemu-devel] [PATCH V3 0/7] Make QED with live migration safe Stefan Hajnoczi
2012-04-04 16:15   ` Benoît Canet
2012-04-05 14:34 ` Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1332488214-4685-7-git-send-email-benoit.canet@gmail.com \
    --to=benoit.canet@gmail.com \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.