From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from 93-97-173-237.zone5.bethere.co.uk ([93.97.173.237] helo=tim.rpsys.net) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1SB3e3-0001FV-S1 for openembedded-core@lists.openembedded.org; Fri, 23 Mar 2012 13:31:04 +0100 Received: from localhost (localhost [127.0.0.1]) by tim.rpsys.net (8.13.6/8.13.8) with ESMTP id q2NCM894026512 for ; Fri, 23 Mar 2012 12:22:08 GMT Received: from tim.rpsys.net ([127.0.0.1]) by localhost (tim.rpsys.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 25941-08 for ; Fri, 23 Mar 2012 12:22:04 +0000 (GMT) Received: from [192.168.3.10] ([192.168.3.10]) (authenticated bits=0) by tim.rpsys.net (8.13.6/8.13.8) with ESMTP id q2NCM11J026506 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Fri, 23 Mar 2012 12:22:02 GMT Message-ID: <1332505323.9740.402.camel@ted> From: Richard Purdie To: Patches and discussions about the oe-core layer Date: Fri, 23 Mar 2012 12:22:03 +0000 In-Reply-To: <20120323114938.GC3879@jama.jama.net> References: <1332485029-9148-1-git-send-email-Martin.Jansa@gmail.com> <1332494193.9740.382.camel@ted> <20120323093623.GB3879@jama.jama.net> <1332502793.9740.385.camel@ted> <20120323114938.GC3879@jama.jama.net> X-Mailer: Evolution 3.2.2- Mime-Version: 1.0 X-Virus-Scanned: amavisd-new at rpsys.net Subject: Re: [PATCH] kernel.bbclass: populate /etc/modules-load.d/ with module_autoload entries too X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Patches and discussions about the oe-core layer List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Mar 2012 12:31:04 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On Fri, 2012-03-23 at 12:49 +0100, Martin Jansa wrote: > On Fri, Mar 23, 2012 at 11:39:53AM +0000, Richard Purdie wrote: > > On Fri, 2012-03-23 at 10:36 +0100, Martin Jansa wrote: > > > On Fri, Mar 23, 2012 at 09:16:33AM +0000, Richard Purdie wrote: > > > > On Fri, 2012-03-23 at 07:43 +0100, Martin Jansa wrote: > > > > > * /etc/modules-load.d/foo.conf is used by systemd like /etc/modutils/foo was with sysvinit > > > > > > > > > > Signed-off-by: Martin Jansa > > > > > --- > > > > > meta/classes/kernel.bbclass | 10 ++++++++-- > > > > > 1 files changed, 8 insertions(+), 2 deletions(-) > > > > > > > > Since these look identical couldn't we symlink them? I'm not a big fan > > > > of writing duplicate data to a package :/. > > > > > > OK I'll change it in v2 > > > > Note that I'm wondering if we can just symlink the directory entirely > > rather than the files themselves. There may be a reason that is a bad > > idea but I don't know... > > There are different filenames (notice .conf in the end) so I have patch > doing symlinks for files not directories. I'd seen the modprobe.d conf files and thought here was some similarity. I have to admit I think systemd is nuts for requiring a copy of these files when it could have used the existing layout. It looks like change for the sake of change :(. I'm nearly tempted to suggest we should just patch systemd to use the other filenames... Cheers, Richard