From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 13/16] drm/i915: extract copy helpers from shmem_pread|pwrite Date: Mon, 26 Mar 2012 10:05:39 +0100 Message-ID: <1332752748_97202@CP5-2952> References: <1332697663-31256-1-git-send-email-daniel.vetter@ffwll.ch> <1332697663-31256-13-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from fireflyinternet.com (smtp.fireflyinternet.com [109.228.6.236]) by gabe.freedesktop.org (Postfix) with ESMTP id 9B852A0896 for ; Mon, 26 Mar 2012 02:05:52 -0700 (PDT) In-Reply-To: <1332697663-31256-13-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Intel Graphics Development Cc: Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org On Sun, 25 Mar 2012 19:47:40 +0200, Daniel Vetter wrote: > While moving around things, this two functions slowly grew out of any > sane bounds. So extract a few lines that do the copying and > clflushing. Also add a few comments to explain what's going on. > > v2: Again do s/needs_clflush/needs_clflush_after/ in the write paths > as suggested by Chris Wilson. > > Signed-Off-by: Daniel Vetter I've tested up to this point and have no further comments to make. (Ok, there is the s/claring/glaring/ spelling mistake ;-) 1-13: Tested-by: Chris Wilson Reviewed-by: Chris Wilson And it turns out I've never used swizzled pwrites. ;) -Chris -- Chris Wilson, Intel Open Source Technology Centre