From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] tune/armv7: Add -mthumb to TUNE_CCARGS
Date: Mon, 26 Mar 2012 12:01:29 +0100 [thread overview]
Message-ID: <1332759689.28414.104.camel@ted> (raw)
In-Reply-To: <1332694123-5078-1-git-send-email-raj.khem@gmail.com>
On Sun, 2012-03-25 at 09:48 -0700, Khem Raj wrote:
> armv7 is least common denominator of armv7-a
> armv7-m and armv7-r and armv7-m does not support
> ARM instructions but only thumb2 instruction set
> which means armv7 when chosen will complain if
> code is compiled in arm mode which is default
> in OE if not specified other wise
>
> Fixes errors like below
>
> error: target CPU does not support ARM mode
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
> meta/conf/machine/include/arm/arch-armv7.inc | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/meta/conf/machine/include/arm/arch-armv7.inc b/meta/conf/machine/include/arm/arch-armv7.inc
> index 33d9f0d..563a6b4 100644
> --- a/meta/conf/machine/include/arm/arch-armv7.inc
> +++ b/meta/conf/machine/include/arm/arch-armv7.inc
> @@ -4,7 +4,7 @@ ARMPKGARCH ?= "armv7"
>
> TUNEVALID[armv7] = "Enable instructions for ARMv7"
> TUNE_CONFLICTS[armv7] = "armv4 armv5 armv6"
> -TUNE_CCARGS += "${@bb.utils.contains("TUNE_FEATURES", "armv7", "-march=armv7", "", d)}"
> +TUNE_CCARGS += "${@bb.utils.contains("TUNE_FEATURES", "armv7", "-march=armv7 -mthumb", "", d)}"
> MACHINEOVERRIDES .= "${@bb.utils.contains("TUNE_FEATURES", "armv7", ":armv7", "" ,d)}"
>
> require conf/machine/include/arm/arch-armv6.inc
Looking at this file, if the above is true and armv7 can't do anything
other than thumb, shouldn't we just delete the non-thumb configurations
for "armv7"?
Adding in "thumb" to the TUNE_FEATURES should add the -mthumb it needs
to work.
Cheers,
Richard
next prev parent reply other threads:[~2012-03-26 11:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-25 16:48 [PATCH] tune/armv7: Add -mthumb to TUNE_CCARGS Khem Raj
2012-03-26 11:01 ` Richard Purdie [this message]
2012-03-26 11:06 ` Phil Blundell
2012-03-26 11:21 ` Richard Purdie
2012-03-26 14:13 ` Khem Raj
2012-03-26 14:37 ` Phil Blundell
2012-03-26 15:12 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1332759689.28414.104.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.