All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: johan.hedberg@gmail.com
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/2] Bluetooth: Don't increment twice in eir_has_data_type()
Date: Mon, 26 Mar 2012 13:47:31 +0200	[thread overview]
Message-ID: <1332762451.1870.94.camel@aeonflux> (raw)
In-Reply-To: <1332760902-16071-1-git-send-email-johan.hedberg@gmail.com>

Hi Johan,

> The parsed variable is already incremented inside the for-loop so there
> no need to increment it again (not to mention that the code was
> incrementing it the wrong amount).
> 
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
> ---
>  include/net/bluetooth/hci_core.h |    7 +++----
>  1 files changed, 3 insertions(+), 4 deletions(-)

Acked-by: Marcel Holtmann <marcel@holtmann.org>

Regards

Marcel



      parent reply	other threads:[~2012-03-26 11:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-26 11:21 [PATCH 1/2] Bluetooth: Don't increment twice in eir_has_data_type() johan.hedberg
2012-03-26 11:21 ` [PATCH 2/2] Bluetooth: Check for minimum data length " johan.hedberg
2012-03-26 11:48   ` Marcel Holtmann
2012-03-27 16:02   ` Gustavo Padovan
2012-03-26 11:47 ` Marcel Holtmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1332762451.1870.94.camel@aeonflux \
    --to=marcel@holtmann.org \
    --cc=johan.hedberg@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.