From: Joe Perches <joe@perches.com>
To: Kay Sievers <kay@vrfy.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Greg Kroah-Hartmann <greg@kroah.com>
Subject: Re: [PATCH] printk: support structured and multi-facility log messages
Date: Thu, 05 Apr 2012 18:12:48 -0700 [thread overview]
Message-ID: <1333674768.23520.123.camel@joe2Laptop> (raw)
In-Reply-To: <1333655231.725.27.camel@mop>
On Thu, 2012-04-05 at 21:47 +0200, Kay Sievers wrote:
> Better?
>
> [root@mop ~]# cat /dev/kmsg
[]
> 6,5,0; BIOS-e820: 00000000000f0000 - 0000000000100000 (reserved)
> 6,6,0; BIOS-e820: 0000000000100000 - 000000001fffd000 (usable)
> 6 ,7,0; BIOS-e820: 000000001fffd000 - 0000000020000000 (reserved)
Not really, why the space between the 6 and the comma?
> This patch extends printk() to be able to attach arbitrary key/value
> pairs to logged messages,
Bad commit changelog.
It does not extend printk(). printk() is a function call.
It extends the message logging subsystem to include the
printk_emit() and vprintk_emit() functions, which can
add decidedly not arbitrary key/value pairs, but some
additional subsystem specific information.
> - Output of dev_printk() is reliably machine-readable now.
No, it's not.
An output header simply contains additional
structured information. The message portion
can still be arbitrary gobbledygook.
I still think this should be 3 patches not 1.
next prev parent reply other threads:[~2012-04-06 1:12 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-04 19:59 [PATCH] printk: support structured and multi-facility log messages Kay Sievers
2012-04-04 21:05 ` Greg Kroah-Hartmann
2012-04-04 21:14 ` Kay Sievers
2012-04-05 0:31 ` Greg Kroah-Hartmann
2012-04-04 21:16 ` richard -rw- weinberger
2012-04-04 21:20 ` Kay Sievers
2012-04-04 23:51 ` Joe Perches
2012-04-05 0:33 ` Greg Kroah-Hartmann
2012-04-05 0:40 ` Joe Perches
2012-04-05 7:46 ` Kay Sievers
2012-04-05 8:08 ` Sam Ravnborg
2012-04-05 8:35 ` Kay Sievers
2012-04-05 11:44 ` Joe Perches
2012-04-05 8:38 ` Joe Perches
2012-04-05 8:44 ` Kay Sievers
2012-04-05 15:05 ` Ingo Molnar
2012-04-05 15:25 ` Kay Sievers
2012-04-05 17:18 ` Ingo Molnar
2012-04-05 17:09 ` Linus Torvalds
2012-04-05 17:53 ` Linus Torvalds
2012-04-13 13:42 ` Stijn Devriendt
2012-04-05 19:47 ` Kay Sievers
2012-04-06 1:12 ` Joe Perches [this message]
2012-04-06 1:31 ` Linus Torvalds
2012-04-06 3:43 ` Joe Perches
2012-04-06 18:35 ` Kay Sievers
2012-04-08 0:47 ` Joe Perches
2012-04-08 1:02 ` Joe Perches
2012-04-10 17:21 ` Joe Perches
2012-04-11 11:39 ` Eric W. Biederman
2012-04-07 0:26 ` Jiri Kosina
2012-04-07 0:59 ` Joe Perches
2012-04-07 1:14 ` Jiri Kosina
2012-04-07 1:51 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1333674768.23520.123.camel@joe2Laptop \
--to=joe@perches.com \
--cc=greg@kroah.com \
--cc=kay@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.