From: Chris Wilson <chris@chris-wilson.co.uk>
To: Ben Widawsky <ben@bwidawsk.net>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Trigger hangcheck if we detect more a repeating missed IRQ
Date: Wed, 11 Apr 2012 09:18:15 +0100 [thread overview]
Message-ID: <1334132297_361331@CP5-2952> (raw)
In-Reply-To: <20120410165911.7a0dd7b5@bwidawsk.net>
On Tue, 10 Apr 2012 16:59:11 -0700, Ben Widawsky <ben@bwidawsk.net> wrote:
> On Tue, 10 Apr 2012 17:00:41 +0100
> Chris Wilson <chris@chris-wilson.co.uk> wrote:
>
> > On the first instance we just wish to kick the waiters and see if that
> > terminates the wait conditions. If it does not, then we do not want to
> > keep retrying without ever making any forward progress and becoming
> > stuck in a hangcheck loop.
> >
> > Reported-and-tested-by: Lukas Hejtmanek <xhejtman@fi.muni.cz>
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=48209
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>
> I'm still confused about the problem we are purportedly fixing.
>
> This should happen if we've missed an irq (or the watchdog fired too
> soon), and then fires again before the thread has actually woken up to
> realize that is missed the first IRQ?
>
> As for extract the kick_ring bit of code for core hangcheck_elapsed,
> that looks fine. I just don't quite understand the exact problem this
> solves, and can't envision how we hit this case it seems the patch will
> fix.
Sure, just look at the bug report for the garbage we wrote into the
ringbuffers and how we ended up indefinite wait. This is not defense
against normal behaviour but the driver screwing up.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-04-11 8:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-10 16:00 [PATCH] drm/i915: Trigger hangcheck if we detect more a repeating missed IRQ Chris Wilson
2012-04-10 23:59 ` Ben Widawsky
2012-04-11 8:18 ` Chris Wilson [this message]
2012-04-11 20:32 ` Ben Widawsky
2012-04-14 22:12 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1334132297_361331@CP5-2952 \
--to=chris@chris-wilson.co.uk \
--cc=ben@bwidawsk.net \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.