All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Bolle <pebolle@tiscali.nl>
To: Debora Velarde <debora@linux.vnet.ibm.com>,
	Rajiv Andrade <srajiv@linux.vnet.ibm.com>,
	Marcel Selhorst <m.selhorst@sirrix.com>
Cc: tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: [PATCH] [RFC] TPM: be silent if disabled or deactivated
Date: Thu, 12 Apr 2012 11:44:17 +0200	[thread overview]
Message-ID: <1334223857.2439.5.camel@x61.thuisdomein> (raw)

Since v3.3 the TPM security chip on a laptop I use prints two messages
at every boot and every resume:
    tpm_tis 00:0a: A TPM error (6) occurred attempting to read a pcr value
    tpm_tis 00:0a: TPM is disabled/deactivated (0x6)

The second message is just an informational message, indicating that
this chip is deactivated (0x6 is TPM_ERR_DEACTIVATED). That doesn't
bother me. The first message is printed at KERN_ERR level. To me it
seems that it is not an error if a security chip is deactivated or
disabled. So suppress that error message in those two cases.

Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
0) Tested against v3.3. (This laptop is currently tracking the Fedora 16
kernel, which is now v3.3 based.) Applies cleanly to v3.4-rc2.

1) Sent as an RFC because I don't actually use any TPM functionality.
(At least, that's what I think. I'm entirely unfamiliar with TPM.)
Moreover, there are a number of code paths that hit this messages, and
for some of those this patch might hide this error where people still
would like to see it. But my usage probably doesn't trigger those code
paths.

 drivers/char/tpm/tpm.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/char/tpm/tpm.c b/drivers/char/tpm/tpm.c
index 32362cf..40a09b5 100644
--- a/drivers/char/tpm/tpm.c
+++ b/drivers/char/tpm/tpm.c
@@ -473,7 +473,7 @@ static ssize_t transmit_cmd(struct tpm_chip *chip, struct tpm_cmd_t *cmd,
 		return -EFAULT;
 
 	err = be32_to_cpu(cmd->header.out.return_code);
-	if (err != 0)
+	if (err != 0 && err != TPM_ERR_DISABLED && err != TPM_ERR_DEACTIVATED)
 		dev_err(chip->dev, "A TPM error (%d) occurred %s\n", err, desc);
 
 	return err;
-- 
1.7.7.6


             reply	other threads:[~2012-04-12  9:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-12  9:44 Paul Bolle [this message]
2012-04-24 14:47 ` [PATCH] [RFC] TPM: be silent if disabled or deactivated Rajiv Andrade
2012-04-24 16:04   ` Paul Bolle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1334223857.2439.5.camel@x61.thuisdomein \
    --to=pebolle@tiscali.nl \
    --cc=debora@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.selhorst@sirrix.com \
    --cc=srajiv@linux.vnet.ibm.com \
    --cc=tpmdd-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.