[PATCH 1/1] ath6kl: Fix system crash sometimes for USB hotplug

[PATCH 1/1] ath6kl: Fix system crash sometimes for USB hotplug

[raychen]

From: Ray Chen <raychen@qca.qualcomm.com>

System crash because of NULL pointer reference due to
cleanup_scatter is not implemented for USB.

Signed-off-by: Ray Chen <raychen@qca.qualcomm.com>
---
 drivers/net/wireless/ath/ath6kl/usb.c |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)

diff --git a/drivers/net/wireless/ath/ath6kl/usb.c b/drivers/net/wireless/ath/ath6kl/usb.c
index 73aacdd..dfbbe9e 100644
--- a/drivers/net/wireless/ath/ath6kl/usb.c
+++ b/drivers/net/wireless/ath/ath6kl/usb.c
@@ -1037,6 +1037,14 @@ static void ath6kl_usb_stop(struct ath6kl *ar)
 	hif_stop(ar);
 }
 
+static void ath6kl_usb_cleanup_scatter(struct ath6kl *ar)
+{
+	/*
+	 * USB doesn't support it. Just return.
+	 */
+	return;
+}
+
 static const struct ath6kl_hif_ops ath6kl_usb_ops = {
 	.diag_read32 = ath6kl_usb_diag_read32,
 	.diag_write32 = ath6kl_usb_diag_write32,
@@ -1049,6 +1057,7 @@ static const struct ath6kl_hif_ops ath6kl_usb_ops = {
 	.pipe_get_default = ath6kl_usb_get_default_pipe,
 	.pipe_map_service = ath6kl_usb_map_service_pipe,
 	.pipe_get_free_queue_number = ath6kl_usb_get_free_queue_number,
+	.cleanup_scatter = ath6kl_usb_cleanup_scatter,
 };
 
 /* ath6kl usb driver registered functions */
-- 
1.7.0.4

Re: [PATCH 1/1] ath6kl: Fix system crash sometimes for USB hotplug

[Kalle Valo]

On 04/12/2012 03:48 PM, raychen@qca.qualcomm.com wrote:
> From: Ray Chen <raychen@qca.qualcomm.com>
> 
> System crash because of NULL pointer reference due to
> cleanup_scatter is not implemented for USB.
> 
> Signed-off-by: Ray Chen <raychen@qca.qualcomm.com>

Thanks, applied.

Kalle