From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steven Rostedt Subject: Re: ehci_hcd related S3 lockup on ASUS laptops, again Date: Thu, 12 Apr 2012 12:33:22 -0400 Message-ID: <1334248402.23924.337.camel@gandalf.stny.rr.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-pm-bounces@lists.linux-foundation.org Errors-To: linux-pm-bounces@lists.linux-foundation.org To: Alan Stern Cc: jrnieder@gmail.com, Andrey Rahmatullin , linux-pm@lists.linux-foundation.org, USB list , Greg KH List-Id: linux-pm@vger.kernel.org On Thu, 2012-04-12 at 10:28 -0400, Alan Stern wrote: > Hmmm. This is a situation where the wakeup setting might matter. Did > the /sys/bus/pci/devices/0000:00:1[ad].0/power/wakeup files both > contain "enabled" when you ran the test? They're both enabled for me too. > > Here's a diagnostic patch that will give us a little more information. > Keep the previous change (so that pci_prepare_to_sleep gets called > whether ehci-hcd is bound or not) and let's see what it says. Try > doing it both with and without ehci-hcd bound. Running this with "echo > devices >/sys/power/pm_test" ought to be good enough. Where do I read out the dev info? -- Steve > > Alan Stern > > > > Index: usb-3.4/drivers/pci/pci.c > =================================================================== > --- usb-3.4.orig/drivers/pci/pci.c > +++ usb-3.4/drivers/pci/pci.c > @@ -1720,6 +1720,9 @@ int pci_prepare_to_sleep(struct pci_dev > > error = pci_set_power_state(dev, target_state); > > + dev_info(&dev->dev, "target %d wakeup %d error %d\n", > + target_state, device_may_wakeup(&dev->dev), error); > + > if (error) > pci_enable_wake(dev, target_state, false); >