From: "Sjur Brændeland" <sjur.brandeland@stericsson.com>
To: netdev@vger.kernel.org, davem@davemloft.net
Cc: sjurbren@gmail.com, "Sjur Brændeland" <sjur.brandeland@stericsson.com>
Subject: [PATCH net-next 3/4] caif-hsi: Remove stop/start of queue.
Date: Thu, 12 Apr 2012 20:27:26 +0200 [thread overview]
Message-ID: <1334255247-3372-4-git-send-email-sjur.brandeland@stericsson.com> (raw)
In-Reply-To: <1334255247-3372-1-git-send-email-sjur.brandeland@stericsson.com>
CAIF HSI is currently a virtual device. Stopping/starting the
queues is wrong on a virtual device.
Signed-off-by: Sjur Brændeland <sjur.brandeland@stericsson.com>
---
drivers/net/caif/caif_hsi.c | 10 ----------
1 files changed, 0 insertions(+), 10 deletions(-)
diff --git a/drivers/net/caif/caif_hsi.c b/drivers/net/caif/caif_hsi.c
index 9849a23..4253991 100644
--- a/drivers/net/caif/caif_hsi.c
+++ b/drivers/net/caif/caif_hsi.c
@@ -1129,15 +1129,11 @@ static int cfhsi_xmit(struct sk_buff *skb, struct net_device *dev)
static int cfhsi_open(struct net_device *dev)
{
- netif_wake_queue(dev);
-
return 0;
}
static int cfhsi_close(struct net_device *dev)
{
- netif_stop_queue(dev);
-
return 0;
}
@@ -1319,9 +1315,6 @@ int cfhsi_probe(struct platform_device *pdev)
__func__, res);
goto err_net_reg;
}
-
- netif_stop_queue(ndev);
-
return res;
err_net_reg:
@@ -1344,9 +1337,6 @@ static void cfhsi_shutdown(struct cfhsi *cfhsi)
{
u8 *tx_buf, *rx_buf, *flip_buf;
- /* Stop TXing */
- netif_tx_stop_all_queues(cfhsi->ndev);
-
/* going to shutdown driver */
set_bit(CFHSI_SHUTDOWN, &cfhsi->bits);
--
1.7.5.4
next prev parent reply other threads:[~2012-04-12 18:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-12 18:27 [PATCH net-next 0/4] New CAIF features Sjur Brændeland
2012-04-12 18:27 ` [PATCH net-next 1/4] caif: set traffic class for caif packets Sjur Brændeland
2012-04-12 18:27 ` [PATCH net-next 2/4] caif-hsi: robust frame aggregation for HSI Sjur Brændeland
2012-04-12 18:27 ` Sjur Brændeland [this message]
2012-04-12 18:27 ` [PATCH net-next 4/4] caif-hsi: Postpone init of HSI until open() Sjur Brændeland
2012-04-13 15:37 ` [PATCH net-next 0/4] New CAIF features David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1334255247-3372-4-git-send-email-sjur.brandeland@stericsson.com \
--to=sjur.brandeland@stericsson.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=sjurbren@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.