* [PATCH] net/core: simple_strtoul cleanup
@ 2012-04-12 19:28 Shuah Khan
2012-04-12 20:09 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Shuah Khan @ 2012-04-12 19:28 UTC (permalink / raw)
To: davem; +Cc: shuahkhan, netdev, LKML
Changed net/core/net-sysfs.c: netdev_store() to use kstrtoul()
instead of obsolete simple_strtoul().
>From 84371b0ed8b277ec8005fd0efbc73165a8bd72b9 Mon Sep 17 00:00:00 2001
From: Shuah Khan <shuahkhan@gmail.com>
Date: Thu, 12 Apr 2012 10:36:10 -0600
Subject: [PATCH] net/core: simple_strtoul cleanup
Signed-off-by: Shuah Khan <shuahkhan@gmail.com>
---
net/core/net-sysfs.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c
index 4955862..97d0f24 100644
--- a/net/core/net-sysfs.c
+++ b/net/core/net-sysfs.c
@@ -74,15 +74,14 @@ static ssize_t netdev_store(struct device *dev, struct device_attribute *attr,
int (*set)(struct net_device *, unsigned long))
{
struct net_device *net = to_net_dev(dev);
- char *endp;
unsigned long new;
int ret = -EINVAL;
if (!capable(CAP_NET_ADMIN))
return -EPERM;
- new = simple_strtoul(buf, &endp, 0);
- if (endp == buf)
+ ret = kstrtoul(buf, 0, &new);
+ if (ret)
goto err;
if (!rtnl_trylock())
--
1.7.5.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net/core: simple_strtoul cleanup
2012-04-12 19:28 [PATCH] net/core: simple_strtoul cleanup Shuah Khan
@ 2012-04-12 20:09 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2012-04-12 20:09 UTC (permalink / raw)
To: shuahkhan; +Cc: netdev, linux-kernel
From: Shuah Khan <shuahkhan@gmail.com>
Date: Thu, 12 Apr 2012 13:28:13 -0600
> Changed net/core/net-sysfs.c: netdev_store() to use kstrtoul()
> instead of obsolete simple_strtoul().
>
>>From 84371b0ed8b277ec8005fd0efbc73165a8bd72b9 Mon Sep 17 00:00:00 2001
> From: Shuah Khan <shuahkhan@gmail.com>
> Date: Thu, 12 Apr 2012 10:36:10 -0600
> Subject: [PATCH] net/core: simple_strtoul cleanup
>
>
> Signed-off-by: Shuah Khan <shuahkhan@gmail.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-04-12 20:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-12 19:28 [PATCH] net/core: simple_strtoul cleanup Shuah Khan
2012-04-12 20:09 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.