From: "Michel Dänzer" <michel@daenzer.net>
To: alexdeucher@gmail.com
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/radeon/si: add missing radeon_bo_unreserve in si_rlc_init()
Date: Fri, 13 Apr 2012 15:54:49 +0200 [thread overview]
Message-ID: <1334325289.5989.69.camel@thor.local> (raw)
In-Reply-To: <1334261635-7334-1-git-send-email-alexdeucher@gmail.com>
On Don, 2012-04-12 at 16:13 -0400, alexdeucher@gmail.com wrote:
> From: Alex Deucher <alexander.deucher@amd.com>
>
> Forget to unreserve after pinning. This can lead to problems in
> soft reset and resume.
>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
[...]
> @@ -3024,12 +3025,12 @@ int si_rlc_init(struct radeon_device *rdev)
> r = radeon_bo_pin(rdev->rlc.clear_state_obj, RADEON_GEM_DOMAIN_VRAM,
> &rdev->rlc.clear_state_gpu_addr);
> if (r) {
> -
> radeon_bo_unreserve(rdev->rlc.clear_state_obj);
> dev_warn(rdev->dev, "(%d) pin RLC c bo failed\n", r);
> si_rlc_fini(rdev);
> return r;
> }
> + radeon_bo_unreserve(rdev->rlc.clear_state_obj);
>
> return 0;
> }
Instead of these two radeon_bo_unreserve calls, there could be one
between the radeon_bo_pin call and the test of its return value.
Either way,
Reviewed-by: Michel Dänzer <michel.daenzer@amd.com>
--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Debian, X and DRI developer
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2012-04-13 13:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-12 20:13 [PATCH] drm/radeon/si: add missing radeon_bo_unreserve in si_rlc_init() alexdeucher
2012-04-13 13:54 ` Michel Dänzer [this message]
2012-04-13 14:26 ` [PATCH] drm/radeon/si: add missing radeon_bo_unreserve in si_rlc_init() v2 alexdeucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1334325289.5989.69.camel@thor.local \
--to=michel@daenzer.net \
--cc=alexdeucher@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.