From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 05/29] drm/i915: prevent NULL pointer exception when using gmbus Date: Fri, 13 Apr 2012 21:18:17 +0100 Message-ID: <1334348304_415235@CP5-2952> References: <1334347745-11743-1-git-send-email-eugeni.dodonov@intel.com> <1334347745-11743-6-git-send-email-eugeni.dodonov@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from fireflyinternet.com (smtp.fireflyinternet.com [109.228.6.236]) by gabe.freedesktop.org (Postfix) with ESMTP id 648AEA0E1B for ; Fri, 13 Apr 2012 13:18:34 -0700 (PDT) In-Reply-To: <1334347745-11743-6-git-send-email-eugeni.dodonov@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: intel-gfx@lists.freedesktop.org Cc: Eugeni Dodonov List-Id: intel-gfx@lists.freedesktop.org On Fri, 13 Apr 2012 17:08:41 -0300, Eugeni Dodonov wrote: > Prevent a NULL pointer exception when we are trying to retrieve EDID data > from non-existent adapter. This just means that a HDMI with a garbage ddc_bus is never detected. Since we control ddc_bus entirely, it means that the initialisation is completely bogus. Please fix the root cause and not paper over programming bugs. -Chris -- Chris Wilson, Intel Open Source Technology Centre