All of lore.kernel.org
 help / color / mirror / Atom feed
From: Liam Girdwood <lrg@ti.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH] ASoC: core: Return -ENOTSUPP instead of -EINVAL if mute is not supported
Date: Mon, 16 Apr 2012 16:00:33 +0100	[thread overview]
Message-ID: <1334588433.2255.2.camel@odin> (raw)
In-Reply-To: <1334341345-19274-1-git-send-email-broonie@opensource.wolfsonmicro.com>

On Fri, 2012-04-13 at 19:22 +0100, Mark Brown wrote:
> This helps us ignore errors in callers if the operation failed due to not
> being available as opposed to an error.
> 
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
>  sound/soc/soc-core.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
> index 1ff0161..b957e68 100644
> --- a/sound/soc/soc-core.c
> +++ b/sound/soc/soc-core.c
> @@ -3090,7 +3090,7 @@ int snd_soc_dai_digital_mute(struct snd_soc_dai *dai, int mute)
>  	if (dai->driver && dai->driver->ops->digital_mute)
>  		return dai->driver->ops->digital_mute(dai, mute);
>  	else
> -		return -EINVAL;
> +		return -ENOTSUPP;
>  }
>  EXPORT_SYMBOL_GPL(snd_soc_dai_digital_mute);
>  

Acked-by: Liam Girdwood <lrg@ti.com>

      reply	other threads:[~2012-04-16 15:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-13 18:22 [PATCH] ASoC: core: Return -ENOTSUPP instead of -EINVAL if mute is not supported Mark Brown
2012-04-16 15:00 ` Liam Girdwood [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1334588433.2255.2.camel@odin \
    --to=lrg@ti.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=patches@opensource.wolfsonmicro.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.