From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH] Rename public xenstore headers Date: Mon, 16 Apr 2012 16:51:24 +0100 Message-ID: <1334591484.14560.219.camel@zakaz.uk.xensource.com> References: <20120416154210.GA6338@wavehammer.waldi.eu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20120416154210.GA6338@wavehammer.waldi.eu.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Bastian Blank Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On Mon, 2012-04-16 at 16:42 +0100, Bastian Blank wrote: > The xenstore header xs.h is producing conflicts with other software[1]. > > xs is a too short identifier and does not matche the library. Renaming > the headers to xenstore.h and xenstore_lib.h is the easiest way to make > them easy recognizable and prevent furthe problems. Thanks Bastian. This needs a Signed-off-by from you, per the DCO at http://wiki.xen.org/wiki/SubmittingXenPatches For my part: Acked-by: Ian Campbell I can't see a good way to do this in a compatible manner for out of tree users[0], so I think if we are going to make this change then we should make a freeze exception and do it in 4.2 (i.e. rip the plaster off quickly rather than have distros solve this their own way while waiting for 4.3). Ian. [0] apart perhaps from having /usr/include/xen-compat/xs.h and suggesting that people can use -I/usr/include/xen-compat as a bandaid, but at that point they may as well just sed their code, since they may need to support 4.1 anyhow. Ian. > Bastian > > [1]: http://bugs.debian.org/668550