From: Ben Hutchings <bhutchings@solarflare.com>
To: Yuval Mintz <yuvalmin@broadcom.com>
Cc: Giuseppe CAVALLARO <peppe.cavallaro@st.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"rayagond@vayavyalabs.com" <rayagond@vayavyalabs.com>,
"davem@davemloft.net" <davem@davemloft.net>
Subject: Re: [net-next 1/4 (V3)] net: ethtool: add the EEE support
Date: Thu, 19 Apr 2012 16:14:41 +0100 [thread overview]
Message-ID: <1334848481.2426.62.camel@bwh-desktop.uk.solarflarecom.com> (raw)
In-Reply-To: <4F9017C6.8070400@broadcom.com>
On Thu, 2012-04-19 at 16:48 +0300, Yuval Mintz wrote:
> Hi Peppe,
>
> > The "set" will be useful for some eth devices (like the stmmac) that can
> > stop/enable internally the eee capability (at mac level).
>
> If you're already implementing this interface, don't you think it might be
> prudent to create an implementation that can do more than enable/disable
> the interface?
[...]
It's not necessary for anyone to *implement* all of this now, but the
interface should certainly cover any settings that users may reasonably
want to read and configure. As with most ethtool 'set' operations, any
implementation (driver) can disallow changing any or all settings
(-EOPNOTSUPP or -EINVAL) if it's difficult or impossible to implement
them.
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2012-04-19 15:14 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-06 9:29 [net-next 0/4 (V3)] stmmac & EEE support Giuseppe CAVALLARO
2012-04-06 9:29 ` [net-next 1/4 (V3)] net: ethtool: add the " Giuseppe CAVALLARO
2012-04-12 22:26 ` Ben Hutchings
2012-04-16 5:41 ` Giuseppe CAVALLARO
2012-04-19 12:58 ` Giuseppe CAVALLARO
2012-04-19 13:48 ` Yuval Mintz
2012-04-19 15:14 ` Ben Hutchings [this message]
2012-04-19 15:30 ` Ben Hutchings
2012-04-26 7:48 ` Giuseppe CAVALLARO
2012-04-26 17:17 ` Ben Hutchings
2012-04-27 14:11 ` Giuseppe CAVALLARO
2012-04-29 9:20 ` Yuval Mintz
2012-04-29 21:56 ` Ben Hutchings
2012-05-07 5:25 ` Giuseppe CAVALLARO
2012-04-06 9:29 ` [net-next 2/4 (V3)] phy: add the EEE support and the way to access to the MMD regs Giuseppe CAVALLARO
2012-04-06 9:29 ` [net-next 3/4 (V3)] stmmac: add the Energy Efficient Ethernet support Giuseppe CAVALLARO
2012-04-12 20:32 ` David Miller
2012-04-13 6:35 ` Giuseppe CAVALLARO
2012-04-06 9:29 ` [net-next 4/4 (V3)] stmmac: update the driver Documentation and add EEE Giuseppe CAVALLARO
2012-04-06 9:29 ` [PATCH] ethtool: add the EEE option Giuseppe CAVALLARO
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1334848481.2426.62.camel@bwh-desktop.uk.solarflarecom.com \
--to=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=rayagond@vayavyalabs.com \
--cc=yuvalmin@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.