All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lin Ming <ming.m.lin@intel.com>
To: Aaron Lu <aaron.lu@amd.com>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>, lenb <lenb@kernel.org>,
	linux-acpi <linux-acpi@vger.kernel.org>,
	linux-kernel@vger.kernel.org, Zhang Rui <rui.zhang@intel.com>,
	"Huang, Ying" <ying.huang@intel.com>
Subject: Re: [PATCH v2] ACPI: D3 states cleanup
Date: Fri, 20 Apr 2012 13:37:35 +0800	[thread overview]
Message-ID: <1334900255.4927.36.camel@minggr> (raw)
In-Reply-To: <20120420052259.GA21040@localhost.amd.com>

On Fri, 2012-04-20 at 13:23 +0800, Aaron Lu wrote:
> On Fri, Apr 20, 2012 at 11:19:13AM +0800, Lin Ming wrote:
> > On Fri, 2012-04-20 at 10:23 +0800, Aaron Lu wrote:
> > > Hi,
> > > 
> > > On Fri, Apr 20, 2012 at 09:19:09AM +0800, Lin Ming wrote:
> > > > There are two ACPI D3 states defined now:
> > > > ACPI_STATE_D3 and ACPI_STATE_D3_COLD.
> > > > 
> > > > But the uses of these states are not clear/correct in some code.
> > > > For example, some code refer ACPI_STATE_D3 as D3hot and others refer
> > > > it as D3cold.
> > > > 
> > > > This patch introduces ACPI_STATE_D3_HOT to refer to ACPI D3hot state.
> > > > And changes ACPI_STATE_D3 to refer to ACPI D3cold state only.
> > > > Also redefines ACPI_STATE_D3_COLD the same as ACPI_STATE_D3.
> > > > 
> > > 
> > > With this patch now, if a device has _PS3, then we will set its D3hot
> > > flag valid. This doesn't feel right to me, since per our discussion the
> > > other day, we should assume _PS3 will put the device into D3cold.
> > > 
> > > Or do you mean: if _PS3 is available, then both D3hot and D3cold is
> > > valid from the perspective of acpi, it is the individual driver's
> > > responsibility to decide which state is actually valid and will be used.
> > 
> > Right.
> > 
> > ACPI_STATE_D3(same as ACPI_STATE_D3_COLD now) is always valid.
> > 
> 
> I mean, if _PS3 is available, can we say D3hot is valid?

Yes.

Lin Ming


  reply	other threads:[~2012-04-20  5:37 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-20  1:19 [PATCH v2] ACPI: D3 states cleanup Lin Ming
2012-04-20  2:23 ` Aaron Lu
2012-04-20  2:23   ` Aaron Lu
2012-04-20  3:19   ` Lin Ming
2012-04-20  5:23     ` Aaron Lu
2012-04-20  5:23       ` Aaron Lu
2012-04-20  5:37       ` Lin Ming [this message]
2012-04-20  7:47         ` Aaron Lu
2012-04-20  7:47           ` Aaron Lu
2012-04-20 11:12           ` Rafael J. Wysocki
2012-04-20 15:14             ` Lin Ming
2012-04-20 15:14               ` Lin Ming
2012-04-22 11:54               ` Rafael J. Wysocki
2012-04-21  1:36             ` Lu, Aaron
2012-04-21  1:36               ` Lu, Aaron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1334900255.4927.36.camel@minggr \
    --to=ming.m.lin@intel.com \
    --cc=aaron.lu@amd.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjw@sisk.pl \
    --cc=rui.zhang@intel.com \
    --cc=ying.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.