All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v3] cfg80211: Validate legacy rateset.
@ 2012-04-20 13:42 Bala Shanmugam
  0 siblings, 0 replies; only message in thread
From: Bala Shanmugam @ 2012-04-20 13:42 UTC (permalink / raw)
  To: linville; +Cc: linux-wireless, Bala Shanmugam

Legacy rates are not validated while configuring
tx rateset using iw. So below cmd is accepted by nl80211.
sudo iw wlan2 set bitrates legacy-2.4 1 2 3

Validate legacy rates and return
error if any rate in the rateset is not valid.

Signed-off-by: Bala Shanmugam <bkamatch@qca.qualcomm.com>
---
v2: Allow empty rateset
v3: Indentation
 net/wireless/nl80211.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
index bcf6f70..140c1d2 100644
--- a/net/wireless/nl80211.c
+++ b/net/wireless/nl80211.c
@@ -5577,6 +5577,9 @@ static int nl80211_set_tx_bitrate_mask(struct sk_buff *skb,
 				sband,
 				nla_data(tb[NL80211_TXRATE_LEGACY]),
 				nla_len(tb[NL80211_TXRATE_LEGACY]));
+			if ((mask.control[band].legacy == 0) &&
+			    nla_len(tb[NL80211_TXRATE_LEGACY]))
+				return -EINVAL;
 		}
 		if (tb[NL80211_TXRATE_MCS]) {
 			if (!ht_rateset_to_mask(
-- 
1.7.4.1


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2012-04-20 13:43 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-20 13:42 [PATCH v3] cfg80211: Validate legacy rateset Bala Shanmugam

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.