From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from wolverine02.qualcomm.com ([199.106.114.251]:32148 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750706Ab2DTNnH (ORCPT ); Fri, 20 Apr 2012 09:43:07 -0400 From: Bala Shanmugam To: CC: , Bala Shanmugam Subject: [PATCH v3] cfg80211: Validate legacy rateset. Date: Fri, 20 Apr 2012 19:12:58 +0530 Message-ID: <1334929378-10899-1-git-send-email-bkamatch@qca.qualcomm.com> (sfid-20120420_154312_258874_AE731753) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org List-ID: Legacy rates are not validated while configuring tx rateset using iw. So below cmd is accepted by nl80211. sudo iw wlan2 set bitrates legacy-2.4 1 2 3 Validate legacy rates and return error if any rate in the rateset is not valid. Signed-off-by: Bala Shanmugam --- v2: Allow empty rateset v3: Indentation net/wireless/nl80211.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c index bcf6f70..140c1d2 100644 --- a/net/wireless/nl80211.c +++ b/net/wireless/nl80211.c @@ -5577,6 +5577,9 @@ static int nl80211_set_tx_bitrate_mask(struct sk_buff *skb, sband, nla_data(tb[NL80211_TXRATE_LEGACY]), nla_len(tb[NL80211_TXRATE_LEGACY])); + if ((mask.control[band].legacy == 0) && + nla_len(tb[NL80211_TXRATE_LEGACY])) + return -EINVAL; } if (tb[NL80211_TXRATE_MCS]) { if (!ht_rateset_to_mask( -- 1.7.4.1