All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
	Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>,
	Ingo Molnar <mingo@redhat.com>,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] tracing: Remove an unneeded check
Date: Fri, 20 Apr 2012 09:51:21 -0400	[thread overview]
Message-ID: <1334929881.28106.77.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <20120420063145.GA22649@elgon.mountain>

On Fri, 2012-04-20 at 09:31 +0300, Dan Carpenter wrote:
> memcpy() returns a pointer to "bug".  Hopefully, it's not NULL here or
> we would already have Oopsed.

You're right that the ret is useless, and the real bug was already fixed
(the possibility that buf could be an invalid pointer).

Not only is this needed, but also get rid of the ret < 0 check in
tracing_splice_read_pipe().

-- Steve



WARNING: multiple messages have this Message-ID
From: Steven Rostedt <rostedt@goodmis.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
	Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>,
	Ingo Molnar <mingo@redhat.com>,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] tracing: Remove an unneeded check
Date: Fri, 20 Apr 2012 13:51:21 +0000	[thread overview]
Message-ID: <1334929881.28106.77.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <20120420063145.GA22649@elgon.mountain>

On Fri, 2012-04-20 at 09:31 +0300, Dan Carpenter wrote:
> memcpy() returns a pointer to "bug".  Hopefully, it's not NULL here or
> we would already have Oopsed.

You're right that the ret is useless, and the real bug was already fixed
(the possibility that buf could be an invalid pointer).

Not only is this needed, but also get rid of the ret < 0 check in
tracing_splice_read_pipe().

-- Steve



  reply	other threads:[~2012-04-20 13:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-20  6:31 Dan Carpenter
2012-04-20  6:31 ` Dan Carpenter
2012-04-20 13:51 ` Steven Rostedt [this message]
2012-04-20 13:51   ` Steven Rostedt
2012-04-20 14:03   ` Dan Carpenter
2012-04-20 14:03     ` Dan Carpenter
2012-04-20 14:26     ` Steven Rostedt
2012-04-20 14:26       ` Steven Rostedt
2012-05-02 21:02 ` [tip:perf/core] tracing: Remove an unneeded check in trace_seq_buffer() tip-bot for Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1334929881.28106.77.camel@gandalf.stny.rr.com \
    --to=rostedt@goodmis.org \
    --cc=dan.carpenter@oracle.com \
    --cc=eduard.munteanu@linux360.ro \
    --cc=fweisbec@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --subject='Re: [patch] tracing: Remove an unneeded check' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.