From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: linux-nfs-owner@vger.kernel.org Received: from mx2.netapp.com ([216.240.18.37]:60895 "EHLO mx2.netapp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753966Ab2DWVH6 (ORCPT ); Mon, 23 Apr 2012 17:07:58 -0400 From: "Myklebust, Trond" To: Chuck Lever CC: "linux-nfs@vger.kernel.org" Subject: Re: [PATCH 05/20] NFS: Clean up return code checking in nfs4_proc_exchange_id() Date: Mon, 23 Apr 2012 21:07:27 +0000 Message-ID: <1335215247.11427.25.camel@lade.trondhjem.org> References: <20120423205312.11446.67081.stgit@degas.1015granger.net> <20120423205350.11446.78215.stgit@degas.1015granger.net> In-Reply-To: <20120423205350.11446.78215.stgit@degas.1015granger.net> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-nfs-owner@vger.kernel.org List-ID: T24gTW9uLCAyMDEyLTA0LTIzIGF0IDE2OjUzIC0wNDAwLCBDaHVjayBMZXZlciB3cm90ZToNCj4g Q2xlYW4gdXA6IHByZWZlciB1c2luZyB0aGUgcHJvcGVyIHR5cGVzIGluICJpZiIgZXhwcmVzc2lv bnMuDQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBDaHVjayBMZXZlciA8Y2h1Y2subGV2ZXJAb3JhY2xl LmNvbT4NCj4gLS0tDQo+IA0KPiAgZnMvbmZzL25mczRwcm9jLmMgfCAgIDE2ICsrKysrKysrLS0t LS0tLS0NCj4gIDEgZmlsZXMgY2hhbmdlZCwgOCBpbnNlcnRpb25zKCspLCA4IGRlbGV0aW9ucygt KQ0KPiANCj4gZGlmZiAtLWdpdCBhL2ZzL25mcy9uZnM0cHJvYy5jIGIvZnMvbmZzL25mczRwcm9j LmMNCj4gaW5kZXggMzc3OGU0Zi4uMGFmNjU3ZCAxMDA2NDQNCj4gLS0tIGEvZnMvbmZzL25mczRw cm9jLmMNCj4gKysrIGIvZnMvbmZzL25mczRwcm9jLmMNCj4gQEAgLTUwMzgsMzAgKzUwMzgsMzAg QEAgaW50IG5mczRfcHJvY19leGNoYW5nZV9pZChzdHJ1Y3QgbmZzX2NsaWVudCAqY2xwLCBzdHJ1 Y3QgcnBjX2NyZWQgKmNyZWQpDQo+ICANCj4gIAlyZXMuc2VydmVyX3Njb3BlID0ga3phbGxvYyhz aXplb2Yoc3RydWN0IG5mczQxX3NlcnZlcl9zY29wZSksDQo+ICAJCQkJCUdGUF9LRVJORUwpOw0K PiAtCWlmICh1bmxpa2VseSghcmVzLnNlcnZlcl9zY29wZSkpIHsNCj4gKwlpZiAodW5saWtlbHko cmVzLnNlcnZlcl9zY29wZSA9PSBOVUxMKSkgew0KPiAgCQlzdGF0dXMgPSAtRU5PTUVNOw0KPiAg CQlnb3RvIG91dDsNCj4gIAl9DQo+ICANCj4gIAlyZXMuaW1wbF9pZCA9IGt6YWxsb2Moc2l6ZW9m KHN0cnVjdCBuZnM0MV9pbXBsX2lkKSwgR0ZQX0tFUk5FTCk7DQo+IC0JaWYgKHVubGlrZWx5KCFy ZXMuaW1wbF9pZCkpIHsNCj4gKwlpZiAodW5saWtlbHkocmVzLmltcGxfaWQgPT0gTlVMTCkpIHsN Cj4gIAkJc3RhdHVzID0gLUVOT01FTTsNCj4gIAkJZ290byBvdXRfc2VydmVyX3Njb3BlOw0KPiAg CX0NCj4gIA0KPiAgCXN0YXR1cyA9IHJwY19jYWxsX3N5bmMoY2xwLT5jbF9ycGNjbGllbnQsICZt c2csIFJQQ19UQVNLX1RJTUVPVVQpOw0KPiAtCWlmICghc3RhdHVzKQ0KPiArCWlmIChzdGF0dXMg PT0gTkZTNF9PSykNCg0KTm8uLi4NCg0KJ3N0YXR1cycgaXMgYW4gb3JkaW5hcnkgaW50ZWdlciB2 YWx1ZS4gSXQgaXMgbm90IGEgc3BlY2lhbA0KTkZTNF90aGlzdGhhdG9ydGhlb3RoZXIuLi4NCg0K DQoNCi0tIA0KVHJvbmQgTXlrbGVidXN0DQpMaW51eCBORlMgY2xpZW50IG1haW50YWluZXINCg0K TmV0QXBwDQpUcm9uZC5NeWtsZWJ1c3RAbmV0YXBwLmNvbQ0Kd3d3Lm5ldGFwcC5jb20NCg0K