From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH v3 3/5] libxl: call hotplug scripts from
 libxl	for vbd
Date: Tue, 24 Apr 2012 11:17:10 +0100
Message-ID: <1335262630.4347.73.camel@zakaz.uk.xensource.com>
References: <1334928211-29856-1-git-send-email-roger.pau@citrix.com>
	<1334928211-29856-4-git-send-email-roger.pau@citrix.com>
	<20373.34767.584624.953798@mariner.uk.xensource.com>
	<1335258998.4347.59.camel@zakaz.uk.xensource.com>
	<20374.31730.484142.339795@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20374.31730.484142.339795@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>, Roger Pau Monne <roger.pau@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Tue, 2012-04-24 at 11:09 +0100, Ian Jackson wrote:
> Ian Campbell writes ("Re: [Xen-devel] [PATCH v3 3/5] libxl: call hotplug scripts from libxl	for vbd"):

> > > Also: this xenstore path should be a relative path, ie one relative to
> > > the xenstore home of domain running this part of the tools.  That way
> > > the scripts can be easily and automatically disabled for dom0 and
> > > enabled in driver domains.
> > 
> > XENBUS_PATH contains elements for both the back- and frontend domains as
> > well as the specific device.
> > 
> > Or do you think the key should be global per-(backend-domain rather than
> > per-device?
> 
> The latter.

So /libxl/$XENBUS_PATH is ok then?

> > > These names are rather too generic, I think.
> > 
> > enums should also be declared in lixl_types_internal.idl
> 
> Surely an enum which doesn't escape from inside libxl and which never
> needs to be printed can just be an enum ?

Sure.