From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915: create macros to handle masked bits Date: Tue, 24 Apr 2012 14:24:33 +0100 Message-ID: <1335273904_37656@CP5-2952> References: <1335269052-18582-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from fireflyinternet.com (smtp.fireflyinternet.com [109.228.6.236]) by gabe.freedesktop.org (Postfix) with ESMTP id 001E6A0A14 for ; Tue, 24 Apr 2012 06:25:10 -0700 (PDT) In-Reply-To: <1335269052-18582-1-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Intel Graphics Development Cc: Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org On Tue, 24 Apr 2012 14:04:12 +0200, Daniel Vetter wrote: > ... and put them to so good use. > > Note that there's functional change in vlv clock gating code, we now > no longer spuriously read back the current value of the bit. According > to Bspec the high bits should always read zeror, so ORing this in s/zeror/zero/ > should have no effect. > > Cc: Jesse Barnes > Signed-Off-by: Daniel Vetter The transforms here look fine, just a moment of concern for not repeating the MODE twiddling in init_render_ring after reset. Reviewed-by: Chris Wilson -Chris -- Chris Wilson, Intel Open Source Technology Centre